From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Zhi-Jun You <hujy652@gmail.com>,
jjohnson@kernel.org, Remi Pommarel <repk@triplefau.lt>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org,
Loic Poulain <loic.poulain@oss.qualcomm.com>
Subject: Re: [RFC PATCH] wifi: ath10k: support flush_sta method
Date: Wed, 6 Aug 2025 07:23:53 -0700 [thread overview]
Message-ID: <29ef8aab-06a3-48e2-a370-86b1b2107143@oss.qualcomm.com> (raw)
In-Reply-To: <20250806070005.1429-1-hujy652@gmail.com>
On 8/6/2025 12:00 AM, Zhi-Jun You wrote:
> When a STA is marked as no longer authorized, if the driver doesn't
> implement flush_sta(), mac80211 calls ieee80211_flush_queues() to
> flush hardware queues to avoid sending unencrypted frames.
>
> This has became a problem for ath10k because ieee80211_flush_queues()
> will stop all traffic and call ath10k_flush, which waits until the
> whole HW queue is empty. In a busy environment this will trigger a
> timeout warning and stalls other STAs.
>
> Fix this by implementing flush_sta method using WMI command to flush
> frames of a specific STA.
> Flushed frames will be marked as discard in tx complete indication.
>
> ops->flush_sta will be set to NULL if htt.disable_tx_comp is set to
> true.
>
> Tested-on: QCA9984 hw1.0 PCI 10.4-3.9.0.2-00157
>
> Signed-off-by: Zhi-Jun You <hujy652@gmail.com>
> ---
There is already a patch from Remi pending for this, see:
https://msgid.link/cover.1732293922.git.repk@triplefau.lt
Please see if that series addresses your needs.
First Kalle, and then I, held this back due to lack of internal validation
across supported platforms, but it is actually still on my TODO list:
https://patchwork.kernel.org/project/linux-wireless/list/?series=911851
Let me make one more validation request internally since I know there is at
least one ath10k-based project with active development.
/jeff
next prev parent reply other threads:[~2025-08-06 14:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 7:00 [RFC PATCH] wifi: ath10k: support flush_sta method Zhi-Jun You
2025-08-06 14:23 ` Jeff Johnson [this message]
2025-08-06 15:51 ` Zhi-Jun You
2025-08-06 19:18 ` Nicolas Escande
2025-08-06 14:42 ` Nicolas Escande
2025-08-06 16:27 ` Zhi-Jun You
2025-08-12 14:02 ` Maurer, Florian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=29ef8aab-06a3-48e2-a370-86b1b2107143@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=hujy652@gmail.com \
--cc=jjohnson@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=repk@triplefau.lt \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox