From: Wen Gong <wgong@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v2 1/4] ath10k: enable firmware peer stats info for wmi tlv
Date: Tue, 28 Apr 2020 17:49:27 +0800 [thread overview]
Message-ID: <2c0d03590f2ecf55aaff86e760232807@codeaurora.org> (raw)
In-Reply-To: <87k120eyyl.fsf@kamboji.qca.qualcomm.com>
On 2020-04-28 17:33, Kalle Valo wrote:
> Kalle Valo <kvalo@codeaurora.org> writes:
>
>> Wen Gong <wgong@codeaurora.org> wrote:
>>
>>> For wmi tlv type, firmware disable peer stats info by default, after
>>> enable it, firmware will report WMI_TLV_PEER_STATS_INFO_EVENTID if
>>> ath10k send WMI_TLV_REQUEST_PEER_STATS_INFO_CMDID to firmware.
>>>
>>> Enable it will only set a flag in firmware, firmware will not report
>>> it without receive request WMI command.
>>>
>>> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00042.
>>>
>>> Signed-off-by: Wen Gong <wgong@codeaurora.org>
>>> Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
>>
>> 4 patches applied to ath-next branch of ath.git, thanks.
>>
>> 2289bef25e32 ath10k: enable firmware peer stats info for wmi tlv
>> 0f7cb26830a6 ath10k: add rx bitrate report for SDIO
>> 3344b99d69ab ath10k: add bitrate parse for peer stats info
>> 4cc02c7c1494 ath10k: correct tx bitrate of iw for SDIO
>
> I think these caused a new warning which I missed:
>
> drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: warning: incorrect
> type in assignment (different base types)
> drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: expected
> restricted __le32 [usertype] reset_after_request
> drivers/net/wireless/ath/ath10k/wmi-tlv.c:3013:34: got unsigned int
> [usertype] reset
ok. I will give new patch to fix the 3 warning.
>
> Please send a followup patch to fix that.
next prev parent reply other threads:[~2020-04-28 9:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 8:04 [PATCH v2 0/4] ath10k: sdio: add support for rx/tx bitrate reporting Wen Gong
2020-04-27 8:04 ` [PATCH v2 1/4] ath10k: enable firmware peer stats info for wmi tlv Wen Gong
2020-04-28 9:13 ` Kalle Valo
[not found] ` <20200428091303.089AEC433D2@smtp.codeaurora.org>
2020-04-28 9:33 ` Kalle Valo
2020-04-28 9:49 ` Wen Gong [this message]
2020-04-27 8:04 ` [PATCH v2 2/4] ath10k: add rx bitrate report for SDIO Wen Gong
2020-04-27 8:04 ` [PATCH v2 3/4] ath10k: add bitrate parse for peer stats info Wen Gong
2020-04-27 8:04 ` [PATCH v2 4/4] ath10k: correct tx bitrate of iw for SDIO Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2c0d03590f2ecf55aaff86e760232807@codeaurora.org \
--to=wgong@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).