From: Ping-Ke Shih <pkshih@realtek.com>
To: Alastair D'Silva <alastair@d-silva.org>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
Kalle Valo <kvalo@kernel.org>
Cc: Luka Gejak <luka.gejak@linux.dev>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Ulf Hansson <ulfh@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH rtw-next v10 3/4] wifi: rtw88: sdio: Fix unhandled RX request interrupt storm
Date: Tue, 17 Nov 2026 06:20:05 +0000 [thread overview]
Message-ID: <2e70b353e2584643a278100a5d64b6ae@realtek.com> (raw)
In-Reply-To: <20261113082242.2773369-4-alastair@d-silva.org>
Alastair D'Silva <alastair@d-silva.org> wrote:
> On 3081-based SDIO chips (observed on RTL8821CS; RTL8822BS and RTL8822CS
> are inferred to be affected as they share the 3081 architecture), clearing
> REG_SDIO_HISR_RX_REQUEST requires both a software W1C acknowledge and an
> empty RX FIFO. Masking this bit out before writing back to HISR prevents
> the software acknowledge from happening, leaving the bit asserted even
> after the FIFO is drained and causing an infinite interrupt storm loop
> that locks up the system.
>
> 8051-based chips instead clear this bit in hardware once the RX buffer is
> empty without a W1C writeback, and software must not clear it.
>
> Split rtw_sdio_handle_interrupt() into separate 8051 and 3081 handlers.
> For 3081, disable interrupts via HIMR, acknowledge all pending status
> bits via W1C writeback (preserving the existing full status word
> writeback used on non-RTL8723BS chips, now including
> REG_SDIO_HISR_RX_REQUEST), service pending events, and re-enable
> interrupts under irq_lock if still running.
>
> If unread packets remain in the FIFO when interrupts are re-enabled (or
> if new packets arrived), REG_SDIO_HISR_RX_REQUEST remains asserted and
> re-triggers the IRQ line. For 8051 chips, preserve the existing behavior.
>
> Fixes: 65371a3f14e7 ("wifi: rtw88: sdio: Add HCI implementation for SDIO based chipsets")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
Remove this tag across patchset.
> Reviewed-by: Luka Gejak <luka.gejak@linux.dev>
> Signed-off-by: Alastair D'Silva <alastair@d-silva.org>
Acked-by: Ping-Ke Shih <pkshih@realtek.com>
next prev parent reply other threads:[~2026-11-17 6:20 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 8:22 [PATCH rtw-next v10 0/4] wifi: rtw88: sdio: Fix unhandled RX request interrupt storm Alastair D'Silva
2026-11-13 8:22 ` [PATCH rtw-next v10 1/4] wifi: rtw88: sdio: Handle allocation and read errors in rtw_sdio_rxfifo_recv Alastair D'Silva
2026-11-13 8:22 ` [PATCH rtw-next v10 2/4] wifi: rtw88: sdio: Track running state and cancel TX worker on stop Alastair D'Silva
2026-11-17 6:15 ` Ping-Ke Shih
2026-11-13 8:22 ` [PATCH rtw-next v10 3/4] wifi: rtw88: sdio: Fix unhandled RX request interrupt storm Alastair D'Silva
2026-11-17 6:20 ` Ping-Ke Shih [this message]
2026-11-13 8:22 ` [PATCH rtw-next v10 4/4] wifi: rtw88: sdio: Split rtw_sdio_rx_isr into 8051 and 3081 variants Alastair D'Silva
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2e70b353e2584643a278100a5d64b6ae@realtek.com \
--to=pkshih@realtek.com \
--cc=alastair@d-silva.org \
--cc=jernej.skrabec@gmail.com \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=luka.gejak@linux.dev \
--cc=martin.blumenstingl@googlemail.com \
--cc=stable@vger.kernel.org \
--cc=ulfh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox