From: Johannes Berg <johannes@sipsolutions.net>
To: Javier Cardona <javier@cozybit.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: netlink reverts
Date: Sat, 21 May 2011 10:42:11 +0200 [thread overview]
Message-ID: <2eafee5b7a180c891df4a9ca53e90d7d@secure.sipsolutions.net> (raw)
In-Reply-To: <BANLkTikjDhdYMssyivgRxAyB5-_FctQbSg@mail.gmail.com> (sfid-20110521_020555_443340_BC05C9C9)
On Fri, 20 May 2011 17:05:12 -0700, Javier Cardona wrote:
> Don't shoot me, please, it really _was_ a merge issue. My patch did
> not insert anything in the middle:
> https://patchwork.kernel.org/patch/752292 and it was sent a day
> before you sent the patch adding WoWLAN support:
> https://patchwork.kernel.org/patch/753772/
Yeah, my mistake, sorry :( I spent half an hour trying to figure out
why wowlan was just not doing anything and got really confused...
I wonder what we can do to fix it. Reverting it doesn't really help
anyone either. I have WoWLAN committed in iw and it suddenly fails
working in mysterious ways because of the added attribute. I suppose you
have the same problem somewhere with the mesh tools though? Maybe we can
just move the plink attribute? iw's master branch already has the wowlan
code ... But I could just as well update nl80211.h in iw I suppose since
it's all not released anyway, thoughts?
johannes
next prev parent reply other threads:[~2011-05-21 8:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-20 18:57 netlink reverts Johannes Berg
2011-05-20 18:59 ` Johannes Berg
2011-05-21 0:05 ` Javier Cardona
2011-05-21 8:42 ` Johannes Berg [this message]
2011-05-21 15:40 ` Javier Cardona
2011-05-24 15:49 ` Johannes Berg
2011-05-24 15:58 ` Eliad Peller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2eafee5b7a180c891df4a9ca53e90d7d@secure.sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=javier@cozybit.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox