Linux wireless drivers development
 help / color / mirror / Atom feed
From: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: "John W . Linville" <linville@tuxdriver.com>,
	<linux-wireless@vger.kernel.org>,
	"Luis R . Rodriguez" <rodrigue@qca.qualcomm.com>,
	Jouni Malinen <jouni@qca.qualcomm.com>
Subject: Scalable approach for nl80211_feature_flags
Date: Mon, 27 Aug 2012 18:32:01 +0300	[thread overview]
Message-ID: <3206344.1tm1fpsF4D@lx-vladimir> (raw)
In-Reply-To: <1345967092.3622.2.camel@jlt4.sipsolutions.net>

Hi,

There is 'new' approach for specifying various wifi driver flags,
using enum nl80211_feature_flags and wiphy.features.

Problem is, wiphy.features is u32, i.e. it is not scalable
beyond 32 flags.

I propose to re-define 'features' approach - convert it to
use 'bitmap' API like DECLARE_BITMAP for the 'features' and
use bit numbers rather then raw values in the
enum nl80211_feature_flags. Last value will be defined like
NL80211_FEATURE_MAX, and 'features' will auto-size using
DECLARE_BITMAP(features, NL80211_FEATURE_MAX);

Then, user space tools need to be modified as well.

If the direction looks correct, I'll go ahead to prepare patch.

Thanks, Vladimir.

      parent reply	other threads:[~2012-08-27 15:32 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-02 11:33 [PATCH v1] 4-way handshake offloading Vladimir Kondratiev
2012-08-02 11:33 ` [PATCH v1] cfg80211: Support for 4-way handshake offloading for WPA2-Personal Vladimir Kondratiev
2012-08-20 11:20   ` Johannes Berg
2012-08-23 15:54     ` Vladimir Kondratiev
2012-08-23 15:59       ` Johannes Berg
     [not found]         ` <3373913.UaOl7A5Fl4@lx-vladimir>
2012-08-26  7:44           ` Johannes Berg
2012-08-27 15:26             ` Scalable approach for nl80211_feature_flags Vladimir Kondratiev
2012-08-28  9:16               ` Kalle Valo
2012-08-27 15:32             ` Vladimir Kondratiev [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3206344.1tm1fpsF4D@lx-vladimir \
    --to=qca_vkondrat@qca.qualcomm.com \
    --cc=johannes@sipsolutions.net \
    --cc=jouni@qca.qualcomm.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=rodrigue@qca.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox