From: Florian Fainelli <florian@openwrt.org>
To: Arend van Spriel <arend@broadcom.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
Linux Wireless List <linux-wireless@vger.kernel.org>,
Hante Meuleman <meuleman@broadcom.com>
Subject: Re: [PATCH 06/10] brcmfmac: fix big endian bug in i-scan.
Date: Mon, 10 Sep 2012 18:37:32 +0200 [thread overview]
Message-ID: <3265895.MSDQPtTcs3@flexo> (raw)
In-Reply-To: <1347283018-24223-7-git-send-email-arend@broadcom.com>
Hello,
On Monday 10 September 2012 15:16:54 Arend van Spriel wrote:
> From: Hante Meuleman <meuleman@broadcom.com>
>
> ssid len is 32 bit and needs endian conversion for big endian systems.
>
> Signed-off-by: Hante Meuleman <meuleman@broadcom.com>
> Signed-off-by: Arend van Spriel <arend@broadcom.com>
This looks like a candidate for stable.
> ---
> .../net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
> index 4a27ca0..6623f48 100644
> --- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
> +++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c
> @@ -501,8 +501,10 @@ static void brcmf_iscan_prep(struct
brcmf_scan_params_le *params_le,
> params_le->active_time = cpu_to_le32(-1);
> params_le->passive_time = cpu_to_le32(-1);
> params_le->home_time = cpu_to_le32(-1);
> - if (ssid && ssid->SSID_len)
> - memcpy(¶ms_le->ssid_le, ssid, sizeof(struct brcmf_ssid));
> + if (ssid && ssid->SSID_len) {
> + params_le->ssid_le.SSID_len = cpu_to_le32(ssid->SSID_len);
> + memcpy(¶ms_le->ssid_le.SSID, ssid->SSID, ssid->SSID_len);
> + }
> }
>
> static s32
> --
> 1.7.9.5
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-09-10 16:38 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 13:16 [PATCH 00/10] brcmfmac: transmit flow control and e-scan support Arend van Spriel
2012-09-10 13:16 ` [PATCH 01/10] brcmfmac: Stop all net if queues on tx flow halt Arend van Spriel
2012-09-10 13:16 ` [PATCH 02/10] brcmfmac: Add extra data support to firmware event queueing Arend van Spriel
2012-09-10 13:16 ` [PATCH 03/10] brcmfmac: Fix extra data support handling Arend van Spriel
2012-09-10 16:37 ` Florian Fainelli
2012-09-10 13:16 ` [PATCH 04/10] brcmfmac: Add tx flow control on net if queue for USB Arend van Spriel
2012-09-10 13:16 ` [PATCH 05/10] brcmfmac: Clean up scan related code Arend van Spriel
2012-09-10 13:16 ` [PATCH 06/10] brcmfmac: fix big endian bug in i-scan Arend van Spriel
2012-09-10 16:37 ` Florian Fainelli [this message]
2012-09-10 13:16 ` [PATCH 07/10] brcmfmac: Fix big endian host configuration data Arend van Spriel
2012-09-10 16:38 ` Florian Fainelli
2012-09-10 13:16 ` [PATCH 08/10] brcmfmac: refill buffers on rx protocol error Arend van Spriel
2012-09-10 13:16 ` [PATCH 09/10] brcmfmac: avoid using local usb data Arend van Spriel
2012-09-10 13:16 ` [PATCH 10/10] brcmfmac: add e-scan support Arend van Spriel
2012-09-10 20:59 ` [PATCH 00/10] brcmfmac: transmit flow control and " Arend van Spriel
2012-09-11 18:49 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3265895.MSDQPtTcs3@flexo \
--to=florian@openwrt.org \
--cc=arend@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=meuleman@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).