From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C802C32ABD0; Wed, 28 Jan 2026 08:02:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769587325; cv=none; b=ZaTwe0+HWLFSig894oBQWlKSpJKuc1dDoffOUNDNL2VBax/NvWvmQTj9+nA2vSgzAIeGnGYHrjUJGsNZzS7KMjCnIah4TCxT6wkAm0tLjvxce8clQzBnh9KELBn/UcK+3SIbqwTV8JkNSvEOXDzIACScUy5voqoVa3LP4pL3Omo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769587325; c=relaxed/simple; bh=T8hcE7eNk2CecyVgSpXssfXRPdfqXP0wzf7C43lxfIg=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WMi71rMwujQnFgxhhu5QonN2U66gbZvRqrkd9c/Ouyes6qGLZZGzH+vtQ6ghO2a30BCwMniGgd2sKxcREgEbnelTyITlB+g/DIBjG30f1a+Qlj0Nh3wNHCsqVclqku6CQ8FY55AHVHNBHz/CWYHE0QPH2d2XF3JyjRGhDtXAWX0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=UHDmGbNQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="UHDmGbNQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 96028C4CEF1; Wed, 28 Jan 2026 08:02:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1769587325; bh=T8hcE7eNk2CecyVgSpXssfXRPdfqXP0wzf7C43lxfIg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=UHDmGbNQe0aHHUS3zjJJwgCzA3D3DhG2XuBWb9TUfx3H/Vo5znrbHiMsfis6GezGi jFJK2dXU8+oVxJnun9gFOZmVe/OcTvAsPZdszEf0R5mvXRMxgqAPIWUP350D3B/vjl 22QEYmHJTbMijnPUinAx0XrMyJWsVOhkHPtSt1PUapeJTfgGZ2T6Fe0g+kMWrgQCXn bKz5XKtjq0RcctFHH39VcS8cTCcQ4hZNFyVKOoqz2VUBF5IQpV83Fefo6iR5Q2WLSU mnSj9+IQ/2FQdXe1DUeGM1DiE2Uy86+Y3BPwTPWyXMW+L/skq9YPsOQU8SGiN4YOvM G5UQbGogsX7Rg== Message-ID: <32845805-5758-4c35-8818-ebccbfd9546a@kernel.org> Date: Wed, 28 Jan 2026 09:01:58 +0100 Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4 ath-current 0/2] wifi: ath11k: add usecase firmware handling based on device compatible To: Jeff Johnson , Miaoqing Pan , jjohnson@kernel.org, johannes@sipsolutions.net, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org Cc: ath11k@lists.infradead.org, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, jonas.gorski@gmail.com References: <20260121095055.3683957-1-miaoqing.pan@oss.qualcomm.com> <74176aab-03d4-4095-890d-7ef1739b914b@oss.qualcomm.com> From: Krzysztof Kozlowski Content-Language: en-US Autocrypt: addr=krzk@kernel.org; keydata= xsFNBFVDQq4BEAC6KeLOfFsAvFMBsrCrJ2bCalhPv5+KQF2PS2+iwZI8BpRZoV+Bd5kWvN79 cFgcqTTuNHjAvxtUG8pQgGTHAObYs6xeYJtjUH0ZX6ndJ33FJYf5V3yXqqjcZ30FgHzJCFUu JMp7PSyMPzpUXfU12yfcRYVEMQrmplNZssmYhiTeVicuOOypWugZKVLGNm0IweVCaZ/DJDIH gNbpvVwjcKYrx85m9cBVEBUGaQP6AT7qlVCkrf50v8bofSIyVa2xmubbAwwFA1oxoOusjPIE J3iadrwpFvsZjF5uHAKS+7wHLoW9hVzOnLbX6ajk5Hf8Pb1m+VH/E8bPBNNYKkfTtypTDUCj NYcd27tjnXfG+SDs/EXNUAIRefCyvaRG7oRYF3Ec+2RgQDRnmmjCjoQNbFrJvJkFHlPeHaeS BosGY+XWKydnmsfY7SSnjAzLUGAFhLd/XDVpb1Een2XucPpKvt9ORF+48gy12FA5GduRLhQU vK4tU7ojoem/G23PcowM1CwPurC8sAVsQb9KmwTGh7rVz3ks3w/zfGBy3+WmLg++C2Wct6nM Pd8/6CBVjEWqD06/RjI2AnjIq5fSEH/BIfXXfC68nMp9BZoy3So4ZsbOlBmtAPvMYX6U8VwD TNeBxJu5Ex0Izf1NV9CzC3nNaFUYOY8KfN01X5SExAoVTr09ewARAQABzSVLcnp5c3p0b2Yg S296bG93c2tpIDxrcnprQGtlcm5lbC5vcmc+wsGVBBMBCgA/AhsDBgsJCAcDAgYVCAIJCgsE FgIDAQIeAQIXgBYhBJvQfg4MUfjVlne3VBuTQ307QWKbBQJoF1BKBQkWlnSaAAoJEBuTQ307 QWKbHukP/3t4tRp/bvDnxJfmNdNVn0gv9ep3L39IntPalBFwRKytqeQkzAju0whYWg+R/rwp +r2I1Fzwt7+PTjsnMFlh1AZxGDmP5MFkzVsMnfX1lGiXhYSOMP97XL6R1QSXxaWOpGNCDaUl ajorB0lJDcC0q3xAdwzRConxYVhlgmTrRiD8oLlSCD5baEAt5Zw17UTNDnDGmZQKR0fqLpWy 786Lm5OScb7DjEgcA2PRm17st4UQ1kF0rQHokVaotxRM74PPDB8bCsunlghJl1DRK9s1aSuN hL1Pv9VD8b4dFNvCo7b4hfAANPU67W40AaaGZ3UAfmw+1MYyo4QuAZGKzaP2ukbdCD/DYnqi tJy88XqWtyb4UQWKNoQqGKzlYXdKsldYqrLHGoMvj1UN9XcRtXHST/IaLn72o7j7/h/Ac5EL 8lSUVIG4TYn59NyxxAXa07Wi6zjVL1U11fTnFmE29ALYQEXKBI3KUO1A3p4sQWzU7uRmbuxn naUmm8RbpMcOfa9JjlXCLmQ5IP7Rr5tYZUCkZz08LIfF8UMXwH7OOEX87Y++EkAB+pzKZNNd hwoXulTAgjSy+OiaLtuCys9VdXLZ3Zy314azaCU3BoWgaMV0eAW/+gprWMXQM1lrlzvwlD/k whyy9wGf0AEPpLssLVt9VVxNjo6BIkt6d1pMg6mHsUEVzsFNBFVDXDQBEADNkrQYSREUL4D3 Gws46JEoZ9HEQOKtkrwjrzlw/tCmqVzERRPvz2Xg8n7+HRCrgqnodIYoUh5WsU84N03KlLue MNsWLJBvBaubYN4JuJIdRr4dS4oyF1/fQAQPHh8Thpiz0SAZFx6iWKB7Qrz3OrGCjTPcW6ei OMheesVS5hxietSmlin+SilmIAPZHx7n242u6kdHOh+/SyLImKn/dh9RzatVpUKbv34eP1wA GldWsRxbf3WP9pFNObSzI/Bo3kA89Xx2rO2roC+Gq4LeHvo7ptzcLcrqaHUAcZ3CgFG88CnA 6z6lBZn0WyewEcPOPdcUB2Q7D/NiUY+HDiV99rAYPJztjeTrBSTnHeSBPb+qn5ZZGQwIdUW9 YegxWKvXXHTwB5eMzo/RB6vffwqcnHDoe0q7VgzRRZJwpi6aMIXLfeWZ5Wrwaw2zldFuO4Dt 91pFzBSOIpeMtfgb/Pfe/a1WJ/GgaIRIBE+NUqckM+3zJHGmVPqJP/h2Iwv6nw8U+7Yyl6gU BLHFTg2hYnLFJI4Xjg+AX1hHFVKmvl3VBHIsBv0oDcsQWXqY+NaFahT0lRPjYtrTa1v3tem/ JoFzZ4B0p27K+qQCF2R96hVvuEyjzBmdq2esyE6zIqftdo4MOJho8uctOiWbwNNq2U9pPWmu 4vXVFBYIGmpyNPYzRm0QPwARAQABwsF8BBgBCgAmAhsMFiEEm9B+DgxR+NWWd7dUG5NDfTtB YpsFAmgXUF8FCRaWWyoACgkQG5NDfTtBYptO0w//dlXJs5/42hAXKsk+PDg3wyEFb4NpyA1v qmx7SfAzk9Hf6lWwU1O6AbqNMbh6PjEwadKUk1m04S7EjdQLsj/MBSgoQtCT3MDmWUUtHZd5 RYIPnPq3WVB47GtuO6/u375tsxhtf7vt95QSYJwCB+ZUgo4T+FV4hquZ4AsRkbgavtIzQisg Dgv76tnEv3YHV8Jn9mi/Bu0FURF+5kpdMfgo1sq6RXNQ//TVf8yFgRtTUdXxW/qHjlYURrm2 H4kutobVEIxiyu6m05q3e9eZB/TaMMNVORx+1kM3j7f0rwtEYUFzY1ygQfpcMDPl7pRYoJjB dSsm0ZuzDaCwaxg2t8hqQJBzJCezTOIkjHUsWAK+tEbU4Z4SnNpCyM3fBqsgYdJxjyC/tWVT AQ18NRLtPw7tK1rdcwCl0GFQHwSwk5pDpz1NH40e6lU+NcXSeiqkDDRkHlftKPV/dV+lQXiu jWt87ecuHlpL3uuQ0ZZNWqHgZoQLXoqC2ZV5KrtKWb/jyiFX/sxSrodALf0zf+tfHv0FZWT2 zHjUqd0t4njD/UOsuIMOQn4Ig0SdivYPfZukb5cdasKJukG1NOpbW7yRNivaCnfZz6dTawXw XRIV/KDsHQiyVxKvN73bThKhONkcX2LWuD928tAR6XMM2G5ovxLe09vuOzzfTWQDsm++9UKF a/A= In-Reply-To: <74176aab-03d4-4095-890d-7ef1739b914b@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 27/01/2026 18:31, Jeff Johnson wrote: > On 1/21/2026 1:50 AM, Miaoqing Pan wrote: >> The 'firmware-name' property was introduced to allow end-users and >> integrators to select use-case-specific firmware for the WCN6855. >> But for M.2 WLAN chips, there is no suitable DTS node to specify >> the 'firmware-name' property. In addition, assigning firmware for >> the M.2 PCIe interface causes chips that do not use use-case-specific >> firmware to fail. Therefore, abandoning the approach of specifying >> firmware in DTS. As an alternative, propose a static lookup table >> mapping device compatible to firmware names. >> >> --- >> v2: >> - Drops `firmware-name` from completely. >> - Updates the commit message to clearly state that the property is >> obsolete and the change is ABI-breaking but safe for upstream. >> v3: >> - Deprecate 'firmware-name' property instead of obsolete. >> - Keep the ABI backwards compatible. >> v4: >> - Use of_machine_is_compatible() to simplify the code. >> - Add back Acked-by tag. >> --- >> >> Miaoqing Pan (2): >> wifi: ath11k: add usecase firmware handling based on device compatible >> dt-bindings: net: wireless: ath11k-pci: deprecate 'firmware-name' >> property >> >> .../net/wireless/qcom,ath11k-pci.yaml | 1 + >> drivers/net/wireless/ath/ath11k/core.c | 27 +++++++++++++++++++ >> drivers/net/wireless/ath/ath11k/core.h | 4 +++ >> 3 files changed, 32 insertions(+) >> >> >> base-commit: d8e1f4a193101a72235416f189b01131a57e26e9 > > Krzysztof, > Since you previously NAKed this series, can you confirm that your review > comments have been addressed? Binding looks fine, but I did not check the driver. Best regards, Krzysztof