From: Sven Eckelmann <se@simonwunderlich.de>
To: "Toke Høiland-Jørgensen" <toke@toke.dk>,
"Kalle Valo" <kvalo@kernel.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>
Cc: linux-wireless@vger.kernel.org,
Simon Wunderlich <sw@simonwunderlich.de>,
Felix Fietkau <nbd@nbd.name>,
ih@simonwunderlich.de
Subject: Re: [PATCH] ath9k: Add RX inactivity detection and reset chip when it occurs
Date: Wed, 06 Nov 2024 14:39:14 +0100 [thread overview]
Message-ID: <3288096.AJdgDx1Vlc@ripper> (raw)
In-Reply-To: <20241106-ath9k-deaf-detection-v1-1-736a150d2425@redhat.com>
Hi,
Thank you for submitting the patch.
On Wednesday, 6 November 2024 13:41:44 CET Toke Høiland-Jørgensen wrote:
> Since this is based on ideas by all three people, but not actually
> directly derived from any of the patches, I'm including Suggested-by
> tags from Simon, Sven and Felix below, which should hopefully serve as
> proper credit.
At least for me, this is more than enough. Thanks.
I don't have the setup at the moment to test it again - maybe Issam can do
this. One concern I would have (because I don't find the notes regarding this
problem), is whether this check is now breaking because we count more things.
In the past, rxlp/rxok was used for the check. And now I don't know whether
the count for the other ones were still increasing.
* RXHP (rather sure that "high priority frame" wasn't increasing)
* RXEOL ("no RX descriptors available" - I would guess no, but I can't say for
sure)
* RXORN ("FIFO overrun" I would guess no, but I can't say for sure)
Reviewed-by: Sven Eckelmann <se@simonwunderlich.de>
Kind regards,
Sven
next prev parent reply other threads:[~2024-11-06 13:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-06 12:41 [PATCH] ath9k: Add RX inactivity detection and reset chip when it occurs Toke Høiland-Jørgensen
2024-11-06 13:39 ` Sven Eckelmann [this message]
2024-11-06 14:12 ` Toke Høiland-Jørgensen
2024-11-06 16:03 ` Simon Wunderlich
2024-11-07 9:36 ` Toke Høiland-Jørgensen
2024-11-18 11:29 ` Hamdi Issam
2024-11-18 12:12 ` Toke Høiland-Jørgensen
2024-11-18 13:06 ` Sven Eckelmann
2024-11-19 12:44 ` Toke Høiland-Jørgensen
2024-11-19 15:34 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3288096.AJdgDx1Vlc@ripper \
--to=se@simonwunderlich.de \
--cc=ih@simonwunderlich.de \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=sw@simonwunderlich.de \
--cc=toke@toke.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).