From: Simon Wunderlich <sw@simonwunderlich.de>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath9k-devel@qca.qualcomm.com,
Nick Kossifidis <mickflemm@gmail.com>
Subject: Re: [PATCH 5/5] ath9k: fix reporting calculated new FFT upper max
Date: Mon, 01 Oct 2018 16:32:25 +0200 [thread overview]
Message-ID: <3368586.snalD90uim@prime> (raw)
In-Reply-To: <87wor1kab5.fsf@kamboji.qca.qualcomm.com>
[-- Attachment #1: Type: text/plain, Size: 866 bytes --]
On Monday, October 1, 2018 5:31:42 PM CEST Kalle Valo wrote:
> Simon Wunderlich <sw@simonwunderlich.de> writes:
> > On Monday, October 1, 2018 2:07:55 PM CEST Kalle Valo wrote:
> >> Simon Wunderlich <sw@simonwunderlich.de> wrote:
> >> > Cc: Nick Kossifidis <mickflemm@gmail.com>
> >> > Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
> >> > Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
> >>
> >> No empty commit logs, please. But I can add that, just tell me what to
> >> add.
> >
> > How about:
> >
> > Since the debug print code is outside of the loop, it shouldn't use the
> > loop iterator anymore but instead print the found maximum index.
>
> Perfect, thanks.
>
> > Let me know if you need me to resend or anything else.
>
> No need, I added this to the patch in the (not yet pushed) pending
> branch.
Awesome, thank you!
Cheers,
Simon
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2018-10-01 14:32 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-19 10:37 [PATCH 0/5] ath9k: FFT fixes and improvements Simon Wunderlich
2018-09-19 10:37 ` [PATCH 1/5] ath9k: add counters for good and errorneous FFT/spectral frames Simon Wunderlich
2018-10-02 4:44 ` Kalle Valo
2018-09-19 10:37 ` [PATCH 2/5] ath9k: return when short FFT frame was handled Simon Wunderlich
2018-09-19 10:37 ` [PATCH 3/5] ath9k: fix and simplify FFT max index retrieval Simon Wunderlich
2018-09-19 10:37 ` [PATCH 4/5] ath9k: FFT magnitude check: don't consider lower 3 data bits Simon Wunderlich
2018-09-19 10:37 ` [PATCH 5/5] ath9k: fix reporting calculated new FFT upper max Simon Wunderlich
2018-10-01 14:07 ` Kalle Valo
[not found] ` <20181001140755.6242260128@smtp.codeaurora.org>
2018-10-01 14:26 ` Simon Wunderlich
2018-10-01 14:31 ` Kalle Valo
2018-10-01 14:32 ` Simon Wunderlich [this message]
2018-09-28 13:09 ` [PATCH 0/5] ath9k: FFT fixes and improvements Tom Psyborg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3368586.snalD90uim@prime \
--to=sw@simonwunderlich.de \
--cc=ath9k-devel@qca.qualcomm.com \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mickflemm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).