public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Ben Greear <greearb@candelatech.com>
To: "Berg, Benjamin" <benjamin.berg@intel.com>,
	"Korenblit, Miriam Rachel" <miriam.rachel.korenblit@intel.com>,
	"johannes@sipsolutions.net" <johannes@sipsolutions.net>
Cc: "linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"Berg, Johannes" <johannes.berg@intel.com>
Subject: Re: [PATCH 06/18] wifi: iwlwifi: keep the TSO and workaround pages mapped
Date: Thu, 18 Jul 2024 12:20:51 -0700	[thread overview]
Message-ID: <3379abec-9251-ac6b-3760-4f1838f31445@candelatech.com> (raw)
In-Reply-To: <4abe931d-f6ec-adb6-9b78-23d4c0c4b1a2@candelatech.com>

On 7/11/24 09:09, Ben Greear wrote:
> On 7/10/24 23:15, Berg, Benjamin wrote:
>> Hi Ben,
>>
>> yes, you need to apply:
>>
>> commit 003eae5a28c6c9d50290a4ac9b955be912f24c9f
>> Author: Benjamin Berg <benjamin.berg@intel.com>
>> Date:   Tue Jul 9 14:31:49 2024 +0200
>>
>>      wifi: iwlwifi: correctly reference TSO page information
>>
>>
>> I had not fully tested the last revision and the error slipped
>> unfortunately.
> 
> Hello Benjamin,
> 
> Sorry I did not notice that patch on the mailing list on my own.  I re-applied
> the 6/18 and 7/18 patches, and the fix you mention above, and system appears stable.

Hello,

We found another regression in our patched 6.10-ish kernel.  Before I apply these 3
patches:

wifi: iwlwifi: keep the TSO and workaround pages mapped
wifi: iwlwifi: use already mapped data when TXing an AMSDU
wifi: iwlwifi: correctly reference TSO page information

Then I see around 4Gbps TCP upload on my test rig.  After this, it runs very poorly,
perhaps bouncing up to high speed for a second or two, but mostly averaging 80Mbps
or so after it runs for a bit.

What are these patches trying to solve, and are you able to see good TCP upload performance
with these patches applied?

Thanks,
Ben


  reply	other threads:[~2024-07-18 19:21 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-03  9:58 [PATCH 00/18] wifi: iwlwifi: updates - 03-07-2024 Miri Korenblit
2024-07-03  9:58 ` [PATCH 01/18] wifi: iwlwifi: mvm: clean up reorder buffer data Miri Korenblit
2024-07-03  9:58 ` [PATCH 02/18] wifi: iwlwifi: mvm: align reorder buffer entries to cacheline Miri Korenblit
2024-07-03  9:58 ` [PATCH 03/18] wifi: iwlwifi: mvm: simplify EMLSR blocking Miri Korenblit
2024-07-03  9:58 ` [PATCH 04/18] wifi: iwlwifi: return a new allocation for hdr page space Miri Korenblit
2024-07-03  9:58 ` [PATCH 05/18] wifi: iwlwifi: map entire SKB when sending AMSDUs Miri Korenblit
2024-07-03  9:58 ` [PATCH 06/18] wifi: iwlwifi: keep the TSO and workaround pages mapped Miri Korenblit
2024-07-10 21:41   ` Ben Greear
2024-07-11  6:15     ` Berg, Benjamin
2024-07-11 16:09       ` Ben Greear
2024-07-18 19:20         ` Ben Greear [this message]
2024-07-19  7:22           ` Berg, Benjamin
2024-07-19 12:30             ` Ben Greear
2024-07-03  9:58 ` [PATCH 07/18] wifi: iwlwifi: use already mapped data when TXing an AMSDU Miri Korenblit
2024-07-03  9:58 ` [PATCH 08/18] wifi: iwlwifi: keep BHs disabled when TXing from reclaim Miri Korenblit
2024-07-03  9:58 ` [PATCH 09/18] wifi: iwlwifi: release TXQ lock during reclaim Miri Korenblit
2024-07-03  9:58 ` [PATCH 10/18] wifi: iwlwifi: mvm: add missing string for ROC EMLSR block Miri Korenblit
2024-07-03  9:58 ` [PATCH 11/18] wifi: iwlwifi: fw: api: fix memory region kernel-doc Miri Korenblit
2024-07-03  9:59 ` [PATCH 12/18] wifi: iwlwifi: fw: api: mac: fix kernel-doc Miri Korenblit
2024-07-03  9:59 ` [PATCH 13/18] wifi: iwlwifi: fw: api: add puncturing to PHY context docs Miri Korenblit
2024-07-03  9:59 ` [PATCH 14/18] wifi: iwlwifi: document PPAG table command union correctly Miri Korenblit
2024-07-03  9:59 ` [PATCH 15/18] wifi: iwlwifi: fw: api: fix missing RX descriptor kernel-doc Miri Korenblit
2024-07-03  9:59 ` [PATCH 16/18] wifi: iwlwifi: mvm: document remaining mvm data Miri Korenblit
2024-07-03  9:59 ` [PATCH 17/18] wifi: iwlwifi: Remove debug message Miri Korenblit
2024-07-03  9:59 ` [PATCH 18/18] wifi: iwlwifi: Add support for LARI_CONFIG_CHANGE_CMD v12 Miri Korenblit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3379abec-9251-ac6b-3760-4f1838f31445@candelatech.com \
    --to=greearb@candelatech.com \
    --cc=benjamin.berg@intel.com \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=miriam.rachel.korenblit@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox