From: Ping-Ke Shih <pkshih@realtek.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Brian Norris <briannorris@chromium.org>,
Francesco Dolcini <francesco@dolcini.it>,
Kalle Valo <kvalo@kernel.org>,
Yogesh Ashok Powar <yogeshp@marvell.com>,
Bing Zhao <bzhao@marvell.com>,
"John W. Linville" <linville@tuxdriver.com>,
Amitkumar Karwar <akarwar@marvell.com>,
"Avinash Patil" <patila@marvell.com>,
Kiran Divekar <dkiran@marvell.com>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: RE: [PATCH] mwifiex: duplicate static structs used in driver instances
Date: Fri, 9 Aug 2024 09:26:48 +0000 [thread overview]
Message-ID: <33fa77bdf10b48a48105f25ebed50fe0@realtek.com> (raw)
In-Reply-To: <ZrXdgIJe6U4sJJwU@pengutronix.de>
Sascha Hauer <s.hauer@pengutronix.de> wrote:
> On Fri, Aug 09, 2024 at 08:49:32AM +0000, Ping-Ke Shih wrote:
> > Sascha Hauer <s.hauer@pengutronix.de> wrote:
> > > + wiphy->bands[NL80211_BAND_2GHZ] = devm_kmemdup(adapter->dev,
> > > + &mwifiex_band_2ghz,
> > > + sizeof(mwifiex_band_2ghz),
> > > + GFP_KERNEL);
> >
> > It seems like you forget to free the duplicate memory somewhere?
>
> It's freed automatically when adapter->dev is released, see the various
> devm_* functions
>
Cool. Thanks for the info.
next prev parent reply other threads:[~2024-08-09 9:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-09 8:11 [PATCH] mwifiex: duplicate static structs used in driver instances Sascha Hauer
2024-08-09 8:14 ` Kalle Valo
2024-08-09 8:23 ` Sascha Hauer
2024-08-09 8:49 ` Ping-Ke Shih
2024-08-09 9:12 ` Sascha Hauer
2024-08-09 9:26 ` Ping-Ke Shih [this message]
2024-08-09 12:42 ` Francesco Dolcini
2024-08-13 16:47 ` Brian Norris
2024-08-16 9:48 ` wifi: " Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33fa77bdf10b48a48105f25ebed50fe0@realtek.com \
--to=pkshih@realtek.com \
--cc=akarwar@marvell.com \
--cc=briannorris@chromium.org \
--cc=bzhao@marvell.com \
--cc=dkiran@marvell.com \
--cc=francesco@dolcini.it \
--cc=kernel@pengutronix.de \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=patila@marvell.com \
--cc=s.hauer@pengutronix.de \
--cc=stable@vger.kernel.org \
--cc=yogeshp@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).