From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49DE9C433E0 for ; Sun, 24 Jan 2021 10:56:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18829227BF for ; Sun, 24 Jan 2021 10:56:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726657AbhAXK4V (ORCPT ); Sun, 24 Jan 2021 05:56:21 -0500 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:30157 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726551AbhAXK4N (ORCPT ); Sun, 24 Jan 2021 05:56:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1611485684; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Jg/MMD3ppMA2CP0HbF4fNM0hbiIyr6unKvNIY/Ca9CQ=; b=gLUuA1EWCRKqhYgXLAuMDPbOyoHPqwZxOoSmE7qA89vswt2vhE5VAazfH4yBtGIcpb3GKv ju8xG1dDaRlkzZD+gkh8c/sSlucGdLefIHDk61tpPhGqIjIqAqOZd7p9/4ejyK2kuL8bhd 9ajdlBivUOGj0F7OOmssG8lVKIerpyU= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-221-n3XEsPGZPoaYGXVqT9YKRw-1; Sun, 24 Jan 2021 05:54:42 -0500 X-MC-Unique: n3XEsPGZPoaYGXVqT9YKRw-1 Received: by mail-ed1-f71.google.com with SMTP id 32so5660191edy.22 for ; Sun, 24 Jan 2021 02:54:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Jg/MMD3ppMA2CP0HbF4fNM0hbiIyr6unKvNIY/Ca9CQ=; b=IjsbdzSereNOP3x+S6Dgvf5dLCiiypNJUoXpVkbh1D8Aj6Jkxxr+tfaQzViuT4dUFi 46Q6vPWGvW78qwcLjBBhwnSaPJntwCK8n7ls6XTG6qEF4AeEGFwzznPo33O2uvH+4zmy 5+qK7Gd6e0qjg31BX4FO/bxJgUg/M45gXfrCYzc3IgM6DZKt4jyw0SZpySi1EAWdZjOX BTuXax/OyFjK3rtZXcglgYXgC+Fbi//ivQbG+hZF2nzRdzm7/ZAP28UERsYJVzBDCQFS kWx0Y9lGMi/G0E6wPLA4ZSFOYNRqjRzFH15AQZuxx9WMjFEPlYOx9zdzJ61QiUOaSRwu zbpQ== X-Gm-Message-State: AOAM5338AMbSfr3trTf4aPm6ww8CiTYFBB7Rxu6zyGwh54IsBhnZxBqQ Q3+MWDKxW0FBbhePVD7dO2rUMoGL1Gr6FElLgOGDVqgnOkQMLGqOz80kekVuOr5zqF1RauVEcW5 krccZ1TSZk3TLK3bQXlDAgwtKNMk= X-Received: by 2002:a50:da8b:: with SMTP id q11mr1101121edj.352.1611485680990; Sun, 24 Jan 2021 02:54:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJycbey/UfEsjUZwK5k6NM43pHiIsZqqRSRgdZMmaBNuDVE2tKEnXnD+E9KsLLan3Pkf0XmrCA== X-Received: by 2002:a50:da8b:: with SMTP id q11mr1101112edj.352.1611485680822; Sun, 24 Jan 2021 02:54:40 -0800 (PST) Received: from x1.localdomain (2001-1c00-0c1e-bf00-37a3-353b-be90-1238.cable.dynamic.v6.ziggo.nl. [2001:1c00:c1e:bf00:37a3:353b:be90:1238]) by smtp.gmail.com with ESMTPSA id e22sm6869120ejd.79.2021.01.24.02.54.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 24 Jan 2021 02:54:40 -0800 (PST) Subject: Re: pull-request: mac80211 2021-01-18.2 To: "Peer, Ilan" , Johannes Berg , "netdev@vger.kernel.org" Cc: "linux-wireless@vger.kernel.org" , "Coelho, Luciano" References: <20210118204750.7243-1-johannes@sipsolutions.net> <77c606d4-a78a-1fa3-5937-b270c3d0bbd3@redhat.com> From: Hans de Goede Message-ID: <348210d8-6940-ca8d-e3b1-f049330a2087@redhat.com> Date: Sun, 24 Jan 2021 11:54:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org Hi, On 1/24/21 10:12 AM, Peer, Ilan wrote: >> -----Original Message----- >> From: Johannes Berg >> Sent: Sunday, January 24, 2021 00:16 >> To: Hans de Goede ; netdev@vger.kernel.org >> Cc: linux-wireless@vger.kernel.org; Peer, Ilan ; >> Coelho, Luciano >> Subject: Re: pull-request: mac80211 2021-01-18.2 >> >> On Sat, 2021-01-23 at 22:31 +0100, Hans de Goede wrote: >>> >>> So I'm afraid that I have some bad news about this patch, it fixes the >>> RCU warning which I reported: >>> >>> https://lore.kernel.org/linux-wireless/20210104170713.66956-1-hdegoede >>> @redhat.com/ >>> >>> But it introduces a deadlock. See: >>> >>> https://lore.kernel.org/linux-wireless/d839ab62-e4bc-56f0-d861-f172bf1 >>> 9c4b3@redhat.com/ >>> >>> for details. Note we really should fix this new deadlock before 5.11 >>> is released. This is worse then the RCU warning which this patch fixes. >> >> Ouch. Thanks for the heads-up. I guess I'll revert both patches for now, >> unless we can quickly figure out a way to get all these paths in order. >> > > Thanks Hans and Johannes for handling this. I'll try to come up with a solution. Great, thank you for looking into this. Let me know if you have a patch which you want me to test on a RTL8723BS adapter. One thing which I forgot to mention earlier, it is not just lockdep complaining this appears to be a real deadlock, the wifi no longer functions, where as it does function with the patch drops. Regards, Hans