From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f49.google.com (mail-wm1-f49.google.com [209.85.128.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F116622D7A0 for ; Fri, 21 Mar 2025 17:35:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742578531; cv=none; b=aOWDPy6nA2N70ssDUmRBQFeBaJFaOVo2HopovFXYq88vzjF8EDRkJTI4yjuL214kthL9auBd4K+dsZxm0AColFEgFudqcWzsiTghLiIQomg0yc/r6U0due604NPlaR6xAoc6eHG7OusAj+xOlu0nC3zzsbSCvXpp/bi7obvyb/4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1742578531; c=relaxed/simple; bh=JnaW8NoZXs1mWMerjoYsGJuJPFqA5xQHNNKpx0jD+CQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=j1uJVUJ4qHKo5ZSwAbehOEWikron4Nr9QbW0h5pE93hnyq2v3nxtgrJ/lGxpCcqWGkaKzs5s4S4jdEtJZ8UCQRoVMM1KI9t65m1n5eDCltDnfTXIOvFFRoW+lbpy1jDYm4ULFXm7b+0zqOzduoDGfUxhaWkj+CbqsheWk6Ah27s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=p2EjPcz9; arc=none smtp.client-ip=209.85.128.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="p2EjPcz9" Received: by mail-wm1-f49.google.com with SMTP id 5b1f17b1804b1-43948f77f1aso14669915e9.0 for ; Fri, 21 Mar 2025 10:35:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1742578528; x=1743183328; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=VM1LB5RPRJUoaX/SK0r0zxXUzjTWyAeypB9AEGb5D3Y=; b=p2EjPcz9BM4N4oyqhJfV2nck8QFPlEZbUTmJD5djEAx+iDJ8+VZT0ouUlZkJLU4qUP h6Xg1aRRY8jBRVbWuObplrcL/EvJ/60ja46jtYARCAYjvnwJOusa5JGWA8nWpH/gxbiG 9L12Yrf06gor2Mywa8VwDOmHIn0NWqtJ0OktoRJtJUvZvxKi42TXmG+neMMe3urpbesA zhOf+0wqU+6Zh2Z6fMk4kjNaDTowgyEjXALV/2yYBPHEk9HpXLfqZXOHME9Izk7g1ACn WD3Gm/zi6cLHpxtWoz6gzypMBwf4BPw9YaroYZz87SdTHKVzOKC4FkMdIzrbdQ8B0Qpg pgPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1742578528; x=1743183328; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VM1LB5RPRJUoaX/SK0r0zxXUzjTWyAeypB9AEGb5D3Y=; b=vycd3h2Xw2DnQWvrk5yHTLPO0U2/TrAFalbuB8gslaGlM7G5vvvtf226NgnqoxFv+s XM/5Hp2Lj7c7pr3R9bu2TMzXDljW/BjCQ7JrRUXbjJ2wtRGoFwOsXyzyi4JYVzjkE1DM kQTpj+wVvhk3RYKfp/lk/4MWRgPAx2t40X/1llh8mM8oouyaKOL5YYYbIv5byJliMMzA a6pG8myEsoYvxSN0TrEZJQJsrtF3FvqcHlzMR1TQkYN2gRgHi9rn4i6oh/OfKFwq639S tM76WTw9/2KcsP4XFZQKWJ4zBJULThgPs3bLO8qZLqivOBRIWKNtMoFzzvGBf4x5r7Bq RoQg== X-Forwarded-Encrypted: i=1; AJvYcCWo4ea0bEvYhVH0+1pGMk3RKCYl85T7ddeGoD1A0i9VLeu97XVLvHnksHM2cBNe5+VY+TPo4KI8umqdJFbPYg==@vger.kernel.org X-Gm-Message-State: AOJu0Yz3wLf9sSUHaXOeEvC8v8bWwR2W38K64FMXPVTcStSdYqSS3cAl abpBmziyKw+PNJuDP8bcG0CBhDON+TJP2CB5+AjW9rjkcyXnbyxg/bebxAoJcJ0duHyzz+hPhxz F X-Gm-Gg: ASbGncslhf8xJkb0/uxgGZASrjeaRM6HFcV2Rlto1diZ4M+TeKI4WAuf9W4g3xq5WP0 V8eIg+86NPgDhBYPRNDrrgb5xb534b80TZT4lDbrBNxRAfz8V8ryBtoF1I0H7z3o8Rk5SHTQZj5 07ZIJZRhtZd02OtBwL8+WEeT4rjHWPkotFw66cTqG5rthcbXzW5bcs5n38IvrnBvycqWSRmO9u0 34DogdmBkmfke6/xNMB5mG6vIoRuG6xxhpiBOt+IHO3MYtVcJryG40zsZV535WyAIaWfjJOxay2 QTLS8ZgwYhWpFNB024v7Ib8mbYftO4M/zD7u9OBMpB5COEtljw== X-Google-Smtp-Source: AGHT+IGjauLF3FiaekujjWRPdiwnm31O9jhDz+mK3nAqpBJ67EtcwutfqHgUb3S2fV6TNS6UHTigjQ== X-Received: by 2002:a05:600c:1c19:b0:43b:cd0d:9466 with SMTP id 5b1f17b1804b1-43d509efa30mr35210415e9.9.1742578528065; Fri, 21 Mar 2025 10:35:28 -0700 (PDT) Received: from localhost ([196.207.164.177]) by smtp.gmail.com with UTF8SMTPSA id 5b1f17b1804b1-43d4fd181b6sm32529655e9.9.2025.03.21.10.35.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 21 Mar 2025 10:35:27 -0700 (PDT) Date: Fri, 21 Mar 2025 20:35:25 +0300 From: Dan Carpenter To: Lorenzo Bianconi Cc: Qasim Ijaz , nbd@nbd.name, ryder.lee@mediatek.com, shayne.chen@mediatek.com, sean.wang@mediatek.com, matthias.bgg@gmail.com, angelogioacchino.delregno@collabora.com, chui-hao.chiu@mediatek.com, Bo.Jiao@mediatek.com, linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH] wifi: mt76: mt7996: prevent uninit return in mt7996_mac_sta_add_links Message-ID: <356de8c6-b3a2-4f7c-9737-011a91c4bdfd@stanley.mountain> References: <20250320201914.48159-1-qasdev00@gmail.com> <46a714fb-8a14-4d24-a0a6-a22cc9d45768@stanley.mountain> Precedence: bulk X-Mailing-List: linux-wireless@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Mar 21, 2025 at 06:14:49PM +0100, Lorenzo Bianconi wrote: > > On Thu, Mar 20, 2025 at 08:19:14PM +0000, Qasim Ijaz wrote: > > > If link_conf_dereference_protected() or mt7996_vif_link() > > > or link_sta_dereference_protected() fail the code jumps to > > > the error_unlink label and returns ret which is uninitialised. > > > > > > Fix this by setting err before jumping to error_unlink. > > > > > > Fixes: c7e4fc362443 ("wifi: mt76: mt7996: Update mt7996_mcu_add_sta to MLO support") > > > Fixes: dd82a9e02c05 ("wifi: mt76: mt7996: Rely on mt7996_sta_link in sta_add/sta_remove callbacks") > > > Signed-off-by: Qasim Ijaz > > > --- > > > drivers/net/wireless/mediatek/mt76/mt7996/main.c | 12 +++++++++--- > > > 1 file changed, 9 insertions(+), 3 deletions(-) > > > > > > diff --git a/drivers/net/wireless/mediatek/mt76/mt7996/main.c b/drivers/net/wireless/mediatek/mt76/mt7996/main.c > > > index 91c64e3a0860..78f7f1fc867e 100644 > > > --- a/drivers/net/wireless/mediatek/mt76/mt7996/main.c > > > +++ b/drivers/net/wireless/mediatek/mt76/mt7996/main.c > > > @@ -998,16 +998,22 @@ mt7996_mac_sta_add_links(struct mt7996_dev *dev, struct ieee80211_vif *vif, > > > continue; > > > > What about if the list is empty or we hit this continue on every link? > > we will return 0 and I guess that's fine, agree? > Fine by me? regards, dan carpenter