Linux wireless drivers development
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev
Subject: Re: [PATCH -next v3 00/13] wifi: cfg80211: consolidate cookie assignment for async ops
Date: Sun, 02 Aug 2026 20:07:15 +0200	[thread overview]
Message-ID: <3673f70c00e5059c644dbac17eca46e020db4233.camel@sipsolutions.net> (raw)
In-Reply-To: <20260731123509.1975281-1-arend.vanspriel@broadcom.com> (sfid-20260731_143523_286560_2029D88D)

On Fri, 2026-07-31 at 14:34 +0200, Arend van Spriel wrote:
> NL80211_ATTR_COOKIE is a userspace-visible u64 that correlates an async
> nl80211 operation with its completion event. Three cfg80211 ops currently
> delegate cookie generation to the driver: remain_on_channel, mgmt_tx, and
> probe_peer. This produces inconsistent strategies across drivers: some use
> an incrementing counter, some use get_random_u32(), some use a CID cast to
> u64, and brcmfmac's mgmt_tx always assigned zero - which is arguably broken
> since cfg80211 treats zero as an invalid cookie.

Thanks for cleaning this up, I've applied it.

Incidentally, this also simplified some changes that I'm slowly
prototyping in this area - I want to queue ethernet frames on the TXQs,
initially at least for client mode, in order to build A-MSDUs at TXQ
dequeue rather than enqueue, and to be able to more easily move frames
from one place to another during SMD transition.

I guess it'll be a while before I'll post _all_ of that though, might
post some prep patches soon with some "further thoughts" in the cover
letter.

johannes

      parent reply	other threads:[~2026-08-02 18:07 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-31 12:34 [PATCH -next v3 00/13] wifi: cfg80211: consolidate cookie assignment for async ops Arend van Spriel
2026-07-31 12:34 ` [PATCH -next v3 01/13] wifi: cfg80211: pre-assign cookie for driver callbacks Arend van Spriel
2026-07-31 12:34 ` [PATCH -next v3 02/13] wifi: mac80211: stop using ieee80211_mgmt_tx_cookie() Arend van Spriel
2026-07-31 12:34 ` [PATCH -next v3 03/13] wifi: ath6kl: use pre-assigned cookie for remain_on_channel and mgmt_tx Arend van Spriel
2026-07-31 12:35 ` [PATCH -next v3 04/13] wifi: wil6210: use pre-assigned cookie for remain_on_channel, mgmt_tx and probe_peer Arend van Spriel
2026-07-31 12:35 ` [PATCH -next v3 05/13] wifi: brcmfmac: use pre-assigned cookie for remain_on_channel and mgmt_tx Arend van Spriel
2026-07-31 12:35 ` [PATCH -next v3 06/13] wifi: mwifiex: " Arend van Spriel
2026-07-31 12:35 ` [PATCH -next v3 07/13] wifi: wilc1000: " Arend van Spriel
2026-07-31 12:35 ` [PATCH -next v3 08/13] wifi: nxpwifi: " Arend van Spriel
2026-07-31 12:35 ` [PATCH -next v3 09/13] wifi: qtnfmac: use pre-assigned cookie for mgmt_tx Arend van Spriel
2026-07-31 12:35 ` [PATCH -next v3 10/13] wifi: rtl8723bs: " Arend van Spriel
2026-07-31 12:35 ` [PATCH -next v3 11/13] wifi: cfg80211: convert cookie output to input parameter Arend van Spriel
2026-07-31 12:35 ` [PATCH -next v3 12/13] wifi: cfg80211: convert tx_control_port cookie " Arend van Spriel
2026-07-31 12:35 ` [PATCH -next v3 13/13] wifi: nl80211: send frame tx status event only for non-zero cookie Arend van Spriel
2026-08-02 18:07 ` Johannes Berg [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3673f70c00e5059c644dbac17eca46e020db4233.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=arend.vanspriel@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox