public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	Sean Anderson <sean.anderson@linux.dev>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] wifi: rtw89: Print only once for unsupported c2h classes
Date: Wed, 30 Jul 2025 00:44:46 +0000	[thread overview]
Message-ID: <36a81df65326472b93c6524b7badb434@realtek.com> (raw)
In-Reply-To: <d2d62793-046c-4b55-93ed-1d1f43cff7f2@gmail.com>

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:
> On 29/07/2025 21:27, Sean Anderson wrote:
> > There are more unsupported functions than just LOWRT_RTY. Improve on
> > commit 3b66519b023b ("wifi: rtw89: phy: add dummy c2h handler to avoid
> > warning message") by printing a message just once when we first
> > encounter an unsupported class. This prevents messages like
> >
> > rtw89_8922ae 0000:81:00.0: PHY c2h class 2 not support
> >
> > from filling up dmesg.
> >
> 
> I also get "MAC c2h class 1 func 3 not support" and "MAC c2h class
> 0 func 6 not support" with RTL8832CU.

These two C2H events were defined as: 

// CLASS 1 - FW_OFLD
#define FWCMD_C2H_FUNC_BEACON_RESEND 0x3

// CLASS 0 - FW_INFO
#define FWCMD_C2H_FUNC_BCN_UPD_DONE 0x06

The implementation of handlers in vendor driver looks like does nothing
needed to be rewritten. Just add a dummy to represent that we have reviewed
the C2H events.



  parent reply	other threads:[~2025-07-30  0:45 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-29 18:27 [PATCH] wifi: rtw89: Print only once for unsupported c2h classes Sean Anderson
2025-07-29 19:44 ` Bitterblue Smith
2025-07-29 20:44   ` [PATCH v2] wifi: rtw89: Print just once for unknown C2H classes Sean Anderson
2025-07-30  0:36     ` Ping-Ke Shih
2025-07-31 20:19       ` Sean Anderson
2025-08-01  0:30         ` Ping-Ke Shih
2025-08-01 14:39           ` Sean Anderson
2025-08-04  1:31             ` Ping-Ke Shih
2025-07-30  3:42     ` Ping-Ke Shih
2025-07-31 20:16       ` Sean Anderson
2025-08-01  0:36         ` Ping-Ke Shih
2025-08-01 14:39           ` Sean Anderson
2025-07-30  0:44   ` Ping-Ke Shih [this message]
2025-08-04  1:33   ` [PATCH] wifi: rtw89: Print only once for unsupported c2h classes Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36a81df65326472b93c6524b7badb434@realtek.com \
    --to=pkshih@realtek.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=rtl8821cerfe2@gmail.com \
    --cc=sean.anderson@linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox