Linux wireless drivers development
 help / color / mirror / Atom feed
From: Arend van Spriel <arend.vanspriel@broadcom.com>
To: LiangCheng Wang <zaq14760@gmail.com>,
	Kalle Valo <kvalo@kernel.org>, Angus Ainslie <angus@akkea.ca>
Cc: Wig Cheng <onlywig@gmail.com>,
	linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
	brcm80211-dev-list.pdl@broadcom.com,
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] wifi: brcmfmac: set F2 blocksize to 256 for BCM43752
Date: Mon, 13 Jul 2026 12:51:45 +0200	[thread overview]
Message-ID: <36f4388a-b856-438c-8ef4-795a7b1eda3e@broadcom.com> (raw)
In-Reply-To: <20260713-b43752-f2-blksz-v1-1-8697fcfeaef4@gmail.com>

On 13/07/2026 10:50, LiangCheng Wang wrote:
> The BCM43752 is not reliable with the default 512-byte SDIO function 2
> block size: on an i.MX8MP board with an AMPAK AP6275S module at
> SDR104 / 200 MHz, an iperf TX stress test kills WLAN within seconds:
> 
>    mmc_submit_one: CMD53 sg block write failed -84
>    brcmf_sdio_dpc: failed backplane access over SDIO, halting operation
> 
> Commit d2587c57ffd8 ("brcmfmac: add 43752 SDIO ids and initialization")
> set up the 43752 like the 4373 for the F2 watermark but missed the F2
> block size, which the 4373 limits to 256 bytes. The vendor driver
> (bcmdhd) also programs a 256-byte F2 block size for this chip and runs
> the same hardware without errors.
> 
> Group the 43752 with the 4373, matching the F2 watermark handling.
> With this change a 10-minute bidirectional iperf3 soak completes with
> zero SDIO errors at ~270 Mbit/s in each direction.
> 
> Fixes: d2587c57ffd8 ("brcmfmac: add 43752 SDIO ids and initialization")
> Cc: stable@vger.kernel.org # <= 6.16 needs the CYPRESS_43752 id name

Looks good to me but the stable instruction looks confusion. What do you 
mean. If there is no 43752 support there is no need for this patch, right?

Regards,
Arend

> Signed-off-by: LiangCheng Wang <zaq14760@gmail.com>
> ---

  reply	other threads:[~2026-07-13 10:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-13  8:50 [PATCH] wifi: brcmfmac: set F2 blocksize to 256 for BCM43752 LiangCheng Wang
2026-07-13 10:51 ` Arend van Spriel [this message]
2026-07-13 11:51   ` Gokul Sivakumar
2026-07-14 16:54     ` Arend van Spriel
2026-07-14  2:28   ` LiangCheng Wang
2026-07-14 17:03     ` Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=36f4388a-b856-438c-8ef4-795a7b1eda3e@broadcom.com \
    --to=arend.vanspriel@broadcom.com \
    --cc=angus@akkea.ca \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=kvalo@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=onlywig@gmail.com \
    --cc=stable@vger.kernel.org \
    --cc=zaq14760@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox