From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 76B8CC433DB for ; Thu, 4 Mar 2021 19:30:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4EBE564F6A for ; Thu, 4 Mar 2021 19:30:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230207AbhCDT3z (ORCPT ); Thu, 4 Mar 2021 14:29:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43310 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230141AbhCDT3Y (ORCPT ); Thu, 4 Mar 2021 14:29:24 -0500 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0BCE2C061574 for ; Thu, 4 Mar 2021 11:28:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=7i8BEbXDXEOW8E286D5JURPRm2okvke1VJqD1R/Oop4=; b=oy/Fil/cXzLyBMkS+Zdzw/o5fK 7sS5AzQoGZaDuDZ6D64Xygfw5oTGh4GSRWmF89/lfkxKv/F1hUPpmUGjWIztDX8GAWjzeXLXee6gL o7RhOqlgUOIWMeDKc9nTWMOeIigFxyBXH20skz2mOiAbT7lM/NTykEzfYmWUcubbcLJ8=; Received: from p4ff13c8d.dip0.t-ipconnect.de ([79.241.60.141] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1lHtdy-0003kA-JI; Thu, 04 Mar 2021 20:28:18 +0100 Subject: Re: [PATCH v4] mt76: mt7615: add missing capabilities for DBDC To: Ryder Lee , Lorenzo Bianconi Cc: Shayne Chen , linux-wireless@vger.kernel.org, linux-mediatek@lists.infradead.org References: <0573b06759c90309b5a6a6e2b6b95796e7db60c7.1614843966.git.ryder.lee@mediatek.com> From: Felix Fietkau Message-ID: <384dc2df-60d7-c6bf-040c-d8583af30a98@nbd.name> Date: Thu, 4 Mar 2021 20:28:17 +0100 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <0573b06759c90309b5a6a6e2b6b95796e7db60c7.1614843966.git.ryder.lee@mediatek.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-03-04 09:55, Ryder Lee wrote: > This improves performance for second phy. > > Signed-off-by: Ryder Lee I actually prefer v1 of this patch. You can fix the init order issues by simply dropping the if (phy->mt76->cap.has_*) checks, since they are not needed at all. - Felix