From: Vladimir Kondratiev <qca_vkondrat@qca.qualcomm.com>
To: Kirshenbaum Erez <erezk@wilocity.com>
Cc: <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH v2] wil6210: Fix AP/PCP start flow
Date: Sun, 9 Jun 2013 17:35:09 +0300 [thread overview]
Message-ID: <3898456.LkS71H2YX8@lx-vladimir> (raw)
In-Reply-To: <1370782371-14694-1-git-send-email-erezk@wilocity.com>
On Sunday, June 09, 2013 03:52:51 PM Kirshenbaum Erez wrote:
> WMI PCP Start flow should not be hanled through:
> net_device_ops->ndo_open()->wil_up()->__wil_up()
> because it missing mandatory FW parameters (SSID,Channel,IEs, Security...).
>
> Prior to AP starting __wil_up() may be called with iftype set
> cfg80211_ops->change_virtual_intf(NL80211_IFTYPE_AP or STATION)
> depend on the application hostapd/wpa_supplicant/iw.
> there should not be an attempt to start an AP flow,
> AP/PCP start flow will be started latter by cfg80211_ops->start_ap().
>
>
> Signed-off-by: Kirshenbaum Erez <erezk@wilocity.com>
Looks good. I fixed typo (s/hanled/handled/) and rebased; submitting as [PATCH v3]...
Thanks, Vladimir
next prev parent reply other threads:[~2013-06-09 14:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-09 12:52 [PATCH v2] wil6210: Fix AP/PCP start flow Kirshenbaum Erez
2013-06-09 14:35 ` Vladimir Kondratiev [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-09 7:01 Kirshenbaum Erez
2013-06-09 10:30 ` Vladimir Kondratiev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3898456.LkS71H2YX8@lx-vladimir \
--to=qca_vkondrat@qca.qualcomm.com \
--cc=erezk@wilocity.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox