From: Valdis.Kletnieks@vt.edu
To: Samuel Thibault <samuel.thibault@ens-lyon.org>
Cc: Hugh Dickins <hughd@google.com>,
akpm@linux-foundation.org, Sabrina Dubroca <sd@queasysnail.net>,
Vincent Donnefort <vdonnefort@gmail.com>,
Bryan Wu <cooloney@gmail.com>,
linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH][input-led] Defer input led work to workqueue
Date: Tue, 26 Aug 2014 14:49:18 -0400 [thread overview]
Message-ID: <3942.1409078958@turing-police.cc.vt.edu> (raw)
In-Reply-To: Your message of "Tue, 26 Aug 2014 03:54:53 +0200." <20140826015453.GA5235@type.youpi.perso.aquilenet.fr>
[-- Attachment #1: Type: text/plain, Size: 870 bytes --]
On Tue, 26 Aug 2014 03:54:53 +0200, Samuel Thibault said:
> This changeset defers the second led_trigger_event call into a
> workqueue, which avoids the nested locking altogether. This does
> not prevent the user from shooting himself in the foot by creating a
> vt::capsl <-> vt-capsl loop, but the only consequence is the workqueue
> threads eating some CPU until the user breaks the loop, which is not too
> bad.
>
> Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
>
> --- a/drivers/input/leds.c
> +++ b/drivers/input/leds.c
> @@ -100,13 +100,25 @@ static unsigned long vt_led_registered[B
I admit having zero understanding of the code, but I can confirm that
next-20140825 still throws the lockdep whine I was seeing, but the same
tree with this patch on top of it boots without warning. Soo...
Tested-By: Valdis Kletnieks <valdis.kletnieks@vt.edu>
[-- Attachment #2: Type: application/pgp-signature, Size: 848 bytes --]
next prev parent reply other threads:[~2014-08-26 18:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-08-26 1:54 [PATCH][input-led] Defer input led work to workqueue Samuel Thibault
2014-08-26 8:01 ` Johannes Berg
2014-08-26 9:13 ` Samuel Thibault
2014-08-26 18:51 ` Valdis.Kletnieks
2014-08-26 9:17 ` [PATCHv2][input-led] " Samuel Thibault
2014-08-26 13:22 ` Johannes Berg
2014-08-26 13:24 ` Samuel Thibault
2014-08-26 13:32 ` Samuel Thibault
2014-08-26 20:41 ` Valdis.Kletnieks
2014-08-26 18:49 ` Valdis.Kletnieks [this message]
2014-08-26 20:02 ` [PATCH][input-led] " Sabrina Dubroca
2014-08-26 21:55 ` Sabrina Dubroca
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3942.1409078958@turing-police.cc.vt.edu \
--to=valdis.kletnieks@vt.edu \
--cc=akpm@linux-foundation.org \
--cc=cooloney@gmail.com \
--cc=hughd@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=sd@queasysnail.net \
--cc=vdonnefort@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).