From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Emmanuel Grumbach <emmanuel.grumbach@intel.com>,
johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org,
miriam.rachel.korenblit@intel.com,
Johannes Berg <johannes.berg@intel.com>
Subject: Re: [PATCH] wifi: nl80211: call kfree without a NULL check
Date: Mon, 20 Oct 2025 07:34:18 -0700 [thread overview]
Message-ID: <39434456-04a5-422c-a42e-9c4ef40dbe8e@oss.qualcomm.com> (raw)
In-Reply-To: <20251020075745.44168-1-emmanuel.grumbach@intel.com>
On 10/20/2025 12:57 AM, Emmanuel Grumbach wrote:
> Coverity is unhappy because we may leak old_radio_rts_threshold.
Is this being flagged in a public Coverity instance?
I don't see this at either of:
https://scan.coverity.com/projects/linux
https://scan.coverity.com/projects/linux-next-weekly-scan
> Fixes: 264637941cf4 ("wifi: cfg80211: Add Support to Set RTS Threshold for each Radio")
If there is a public instance, would be nice to add a Closes: tag that points
to it
> Reviewed-by: Johannes Berg <johannes.berg@intel.com>
Reviewed-by: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
> Signed-off-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
> ---
> net/wireless/nl80211.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c
> index 346dfd2bd987..03d07b54359a 100644
> --- a/net/wireless/nl80211.c
> +++ b/net/wireless/nl80211.c
> @@ -4136,8 +4136,7 @@ static int nl80211_set_wiphy(struct sk_buff *skb, struct genl_info *info)
> rdev->wiphy.txq_quantum = old_txq_quantum;
> }
>
> - if (old_rts_threshold)
> - kfree(old_radio_rts_threshold);
> + kfree(old_radio_rts_threshold);
> return result;
> }
>
next prev parent reply other threads:[~2025-10-20 14:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-20 7:57 [PATCH] wifi: nl80211: call kfree without a NULL check Emmanuel Grumbach
2025-10-20 14:34 ` Jeff Johnson [this message]
2025-10-20 14:38 ` Grumbach, Emmanuel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=39434456-04a5-422c-a42e-9c4ef40dbe8e@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=emmanuel.grumbach@intel.com \
--cc=johannes.berg@intel.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox