From: Jayasaikiran Banigallapati <bjsaikiran@gmail.com>
To: Baochen Qiang <baochen.qiang@oss.qualcomm.com>,
jjohnson@kernel.org, kvalo@kernel.org
Cc: quic_bqiang@quicinc.com, linux-wireless@vger.kernel.org,
ath12k@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] wifi: ath12k: fix CMA error and MHI state mismatch during resume
Date: Tue, 3 Feb 2026 10:32:06 +0530 [thread overview]
Message-ID: <399d4ea0-5f70-4678-b0d6-9a80c3399ceb@gmail.com> (raw)
In-Reply-To: <125f0ecb-79a5-4806-aa93-aecaf937885e@oss.qualcomm.com>
On 2/3/26 08:21, Baochen Qiang wrote:
>
> On 2/2/2026 11:17 PM, Saikiran wrote:
>> Commit 8d5f4da8d70b ("wifi: ath12k: support suspend/resume") introduced
>> system suspend/resume support but caused a critical regression where
>> CMA pages are corrupted during resume.
>>
>> 1. CMA page corruption:
>> Calling mhi_unprepare_after_power_down() during suspend (via
>> ATH12K_MHI_DEINIT) prematurely frees the fbc_image and rddm_image
>> DMA buffers. When these pages are accessed during resume, the kernel
>> detects corruption (Bad page state).
> How, FBC image and RDDM image get re-allocated at resume, no?
>
> To clarify, the BUG: Bad page state crash actually occurs during the
> suspend phase, specifically when ath12k_mhi_stop() calls
> mhi_unprepare_after_power_down().
>
> The stack trace shows the panic happens inside mhi_free_bhie_table()
> while trying to free the pages:
>
> mhi_free_bhie_table+0x50/0xa0 [mhi]
> mhi_unprepare_after_power_down+0x30/0x70 [mhi]
> ath12k_mhi_stop+0xf8/0x210 [ath12k]
> ath12k_core_suspend_late+0x94/0xc0 [ath12k]
>
> The kernel reports nonzero _refcount when attempting to free the CMA
> pages (fbc_image/rddm_image). This suggests that something is still
> holding a reference to these pages when DEINIT attempts to free them,
> causing the kernel to panic before we reach the resume stage.
>
> Since the pages cannot be safely freed during suspend, skipping DEINIT
> (and using MHI_POWER_OFF_KEEP_DEV) avoids this invalid free operation.
> This also aligns with the existing comment in ath12k_mhi_stop which
> suggests using mhi_power_down_keep_dev() for suspend.
>
> Thanks & Regards,
> Saikiran
next prev parent reply other threads:[~2026-02-03 5:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-02 15:17 [PATCH] wifi: ath12k: fix CMA error and MHI state mismatch during resume Saikiran
2026-02-03 2:51 ` Baochen Qiang
2026-02-03 5:02 ` Jayasaikiran Banigallapati [this message]
2026-02-03 5:30 ` Baochen Qiang
2026-02-03 5:51 ` Jayasaikiran Banigallapati
2026-02-03 6:08 ` Baochen Qiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=399d4ea0-5f70-4678-b0d6-9a80c3399ceb@gmail.com \
--to=bjsaikiran@gmail.com \
--cc=ath12k@lists.infradead.org \
--cc=baochen.qiang@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_bqiang@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox