From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0F52C43460 for ; Mon, 12 Apr 2021 14:35:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ACF8E61287 for ; Mon, 12 Apr 2021 14:35:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237558AbhDLOfs (ORCPT ); Mon, 12 Apr 2021 10:35:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56296 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238739AbhDLOfr (ORCPT ); Mon, 12 Apr 2021 10:35:47 -0400 Received: from nbd.name (nbd.name [IPv6:2a01:4f8:221:3d45::2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 04204C061574 for ; Mon, 12 Apr 2021 07:35:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=nbd.name; s=20160729; h=Content-Transfer-Encoding:Content-Type:In-Reply-To: MIME-Version:Date:Message-ID:From:References:To:Subject:Sender:Reply-To:Cc: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=toq0q2Pc+hYbxLquSM14b70SsyEBkW+k389b+Y6cpOY=; b=swfURh6WQrC4Got0sHj/1tvW/1 +S8qgbmyo9J1rwle8j5k7Gdxvo7v879+tAbL4TumEtD8ZTc6LvU8x2/mvMg1zkNcypqBqesXxSXca LMBgoWNjRrnL9fuyp4ya/SwOvJSn5uVG10eeOMhdbOk2Hf+XSIfriQOI+Rtg5lnuFcuk=; Received: from p4ff13c8d.dip0.t-ipconnect.de ([79.241.60.141] helo=nf.local) by ds12 with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.89) (envelope-from ) id 1lVxew-0003xp-GT; Mon, 12 Apr 2021 16:35:26 +0200 Subject: Re: [PATCH] mt76: mt7921: remove 80+80 MHz support capabilities To: Johannes Berg , linux-wireless@vger.kernel.org References: <20210411104751.24103-1-nbd@nbd.name> <18627505ec45f8e5a0e424c3f3f9ca204cb1830c.camel@sipsolutions.net> From: Felix Fietkau Message-ID: <3a8e0269-cf1b-e77f-086e-15c9c1e3a2aa@nbd.name> Date: Mon, 12 Apr 2021 16:35:25 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.16; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <18627505ec45f8e5a0e424c3f3f9ca204cb1830c.camel@sipsolutions.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On 2021-04-12 14:45, Johannes Berg wrote: > On Sun, 2021-04-11 at 12:47 +0200, Felix Fietkau wrote: >> This mode is not supported by the hardware >> > You say this "mode" (singular), and the subject says "80+80", > >> - he_mcs->rx_mcs_160 = cpu_to_le16(mcs_map); >> - he_mcs->tx_mcs_160 = cpu_to_le16(mcs_map); > > but you proceed to also remove 160, was that intentional? Yes. 160 MHz isn't supported and no capability was set for it either. - Felix