public inbox for linux-wireless@vger.kernel.org
 help / color / mirror / Atom feed
From: Ping-Ke Shih <pkshih@realtek.com>
To: Piotr Oniszczuk <piotr.oniszczuk@gmail.com>
Cc: Bitterblue Smith <rtl8821cerfe2@gmail.com>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
	"martin.blumenstingl@googlemail.com"
	<martin.blumenstingl@googlemail.com>
Subject: RE: rtl8822cs, mainline 6.16-rc7: kernel reports ' unsupported rf path'
Date: Thu, 24 Jul 2025 00:52:12 +0000	[thread overview]
Message-ID: <3a93f5580be34135a5b7f942d5b6ea44@realtek.com> (raw)
In-Reply-To: <699C22B4-A3E3-4206-97D0-22AB3348EBF6@gmail.com>

Piotr Oniszczuk <piotr.oniszczuk@gmail.com> wrote:
> > Wiadomość napisana przez Ping-Ke Shih <pkshih@realtek.com> w dniu 23 lip 2025, o godz. 14:23:
> >
> > Thanks for the hints. I think it's worth to try:
> >
> > diff --git a/drivers/net/wireless/realtek/rtw88/main.c b/drivers/net/wireless/realtek/rtw88/main.c
> > index fa0ed39cb199..5ea13c775796 100644
> > --- a/drivers/net/wireless/realtek/rtw88/main.c
> > +++ b/drivers/net/wireless/realtek/rtw88/main.c
> > @@ -1861,6 +1861,8 @@ static int rtw_chip_parameter_setup(struct rtw_dev *rtwdev)
> >        hal->chip_version = rtw_read32(rtwdev, REG_SYS_CFG1);
> >        hal->cut_version = BIT_GET_CHIP_VER(hal->chip_version);
> >        hal->mp_chip = (hal->chip_version & BIT_RTL_ID) ? 0 : 1;
> > +       printk("rtw88: %s:%d hal->chip_version=0x%x\n",
> > +               __func__, __LINE__, hal->chip_version);
> >        if (hal->chip_version & BIT_RF_TYPE_ID) {
> >                hal->rf_type = RF_2T2R;
> >                hal->rf_path_num = 2;
> > diff --git a/drivers/net/wireless/realtek/rtw88/sdio.c b/drivers/net/wireless/realtek/rtw88/sdio.c
> > index cc2d4fef3587..5c9e7c8cdd7e 100644
> > --- a/drivers/net/wireless/realtek/rtw88/sdio.c
> > +++ b/drivers/net/wireless/realtek/rtw88/sdio.c
> > @@ -144,6 +144,10 @@ static u32 rtw_sdio_to_io_address(struct rtw_dev *rtwdev, u32 addr,
> >
> > static bool rtw_sdio_use_direct_io(struct rtw_dev *rtwdev, u32 addr)
> > {
> > +       if (!rtw_sdio_is_bus_addr(addr) &&
> > +           !test_bit(RTW_FLAG_POWERON, rtwdev->flags))
> > +               return false;
> > +
> >        return !rtw_sdio_is_sdio30_supported(rtwdev) ||
> >                rtw_sdio_is_bus_addr(addr);
> > }
> >
> 
> With this change all works ok.
> 15 boots and all 15 were with nice wifi :-)
> 
>  dmesg from working system: https://termbin.com/09a1

I sent a patch [1] with a change that check RTW_FLAG_POWERON flag first, 
so things will be the same as this final try. Still want you test the patch
again, and give me a Tested-by tag there. Thanks.

[1] https://lore.kernel.org/linux-wireless/20250724004815.7043-1-pkshih@realtek.com/T/#u



  reply	other threads:[~2025-07-24  0:52 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-22 13:29 rtl8822cs, mainline 6.16-rc7: kernel reports ' unsupported rf path' Piotr Oniszczuk
2025-07-23  0:52 ` Ping-Ke Shih
2025-07-23  7:34   ` Piotr Oniszczuk
2025-07-23  7:50     ` Ping-Ke Shih
2025-07-23  8:02       ` Piotr Oniszczuk
2025-07-23  8:19         ` Ping-Ke Shih
2025-07-23  8:46           ` Piotr Oniszczuk
2025-07-23  9:07             ` Ping-Ke Shih
2025-07-23 11:14               ` Bitterblue Smith
2025-07-23 12:23                 ` Ping-Ke Shih
2025-07-23 13:02                   ` Piotr Oniszczuk
2025-07-24  0:52                     ` Ping-Ke Shih [this message]
2025-07-24  7:55                       ` Piotr Oniszczuk
2025-07-24  7:59                         ` Ping-Ke Shih

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3a93f5580be34135a5b7f942d5b6ea44@realtek.com \
    --to=pkshih@realtek.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=martin.blumenstingl@googlemail.com \
    --cc=piotr.oniszczuk@gmail.com \
    --cc=rtl8821cerfe2@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox