From: Nick <vincent@systemli.org>
To: Johannes Berg <johannes@sipsolutions.net>,
linux-wireless@vger.kernel.org
Cc: nbd@nbd.name, "David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH] wifi: mac80211: add support for scanning in ap mode
Date: Tue, 10 Jan 2023 13:31:42 +0100 [thread overview]
Message-ID: <3a9c2bae-6c33-2211-1368-85d839680de8@systemli.org> (raw)
In-Reply-To: <9a2e054444a84e2645cf6397934313b0c41fb725.camel@sipsolutions.net>
Sorry, I made a mistake. NL80211_SCAN_FLAG_AP seems to do everything I
want. Initially I thought there was something special about the
"NL80211_FEATURE_AP_SCAN" that was also needed, since it is not being
set by the ath9k. Also, the OpenWrt patch does not test for
"NL80211_FEATURE_AP_SCAN", so I thought it was necessary to skip this
check as well. However, I just noticed that this flag is set for ath9k
in mac80211. I have just tested it again with ath9k (iw dev wlan0 scan
ap-force) and it works as expected.
As far as I know, tools like iwinfo do not include this "force" option.
OpenWrt's Luci interface heavily relies on iwinfo. So far this is not an
issue, as the default behavior of mac80211 in OpenWrt currently allows
scanning regardless of "NL80211_FEATURE_AP_SCAN" or
"NL80211_SCAN_FLAG_AP". So if I want to get rid of this downstream patch
I have to rewrite the iwinfo logic and maybe always include
NL80211_SCAN_FLAG_AP as default.
Thank you very much for your time and feedback.
Bests
Nick
On 1/10/23 12:20, Johannes Berg wrote:
> On Tue, 2023-01-10 at 12:19 +0100, Johannes Berg wrote:
>> On Tue, 2023-01-10 at 12:18 +0100, Nick wrote:
>>> Thanks for your feedback. Can you suggest a better way to do this?
>>>
>> Well there already is NL80211_SCAN_FLAG_AP?
>>
> Oh sorry you want it independent of the driver.
>
> But why? This was primarily a thing for "does the firmware even support
> this".
>
> So really then your driver should set it?
>
> johannes
prev parent reply other threads:[~2023-01-10 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-10 11:05 [PATCH] wifi: mac80211: add support for scanning in ap mode Nick Hainke
2023-01-10 11:07 ` Johannes Berg
2023-01-10 11:18 ` Nick
2023-01-10 11:19 ` Johannes Berg
2023-01-10 11:20 ` Johannes Berg
2023-01-10 12:31 ` Nick [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3a9c2bae-6c33-2211-1368-85d839680de8@systemli.org \
--to=vincent@systemli.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox