From: Pkshih <pkshih@realtek.com>
To: Kalle Valo <kvalo@codeaurora.org>,
"cgel.zte@gmail.com" <cgel.zte@gmail.com>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"kuba@kernel.org" <kuba@kernel.org>,
"lv.ruyi@zte.com.cn" <lv.ruyi@zte.com.cn>,
"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Zeal Robot <zealci@zte.com.cn>
Subject: RE: [PATCH] rtw89: fix error function parameter
Date: Wed, 20 Oct 2021 09:46:09 +0000 [thread overview]
Message-ID: <3aa076f0e39a485ca090f8c14682b694@realtek.com> (raw)
In-Reply-To: <163471982441.1743.9901035714649893101.kvalo@codeaurora.org>
> -----Original Message-----
> From: kvalo=codeaurora.org@mg.codeaurora.org <kvalo=codeaurora.org@mg.codeaurora.org> On Behalf Of Kalle
> Valo
> Sent: Wednesday, October 20, 2021 4:50 PM
> To: cgel.zte@gmail.com
> Cc: davem@davemloft.net; kuba@kernel.org; Pkshih <pkshih@realtek.com>; lv.ruyi@zte.com.cn;
> linux-wireless@vger.kernel.org; netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Zeal Robot
> <zealci@zte.com.cn>
> Subject: Re: [PATCH] rtw89: fix error function parameter
>
> cgel.zte@gmail.com wrote:
>
> > From: Lv Ruyi <lv.ruyi@zte.com.cn>
> >
> > This patch fixes the following Coccinelle warning:
> > drivers/net/wireless/realtek/rtw89/rtw8852a.c:753:
> > WARNING possible condition with no effect (if == else)
> >
> > Reported-by: Zeal Robot <zealci@zte.com.cn>
> > Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> > Acked-by: Ping-Ke Shih <pkshih@realtek.com>
>
> Failed to apply, please rebase on top of wireless-drivers-next.
>
> error: patch failed: drivers/net/wireless/realtek/rtw89/rtw8852a.c:753
> error: drivers/net/wireless/realtek/rtw89/rtw8852a.c: patch does not apply
> error: Did you hand edit your patch?
> It does not apply to blobs recorded in its index.
> hint: Use 'git am --show-current-patch' to see the failed patch
> Applying: rtw89: fix error function parameter
> Using index info to reconstruct a base tree...
> Patch failed at 0001 rtw89: fix error function parameter
>
> Patch set to Changes Requested.
>
I think this is because the patch is translated into spaces instead of tabs,
in this and following statements.
" if (is_2g)"
--
Ping-Ke
next prev parent reply other threads:[~2021-10-20 9:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 3:53 [PATCH] rtw89: fix error function parameter cgel.zte
2021-10-19 5:21 ` Pkshih
2021-10-20 8:50 ` Kalle Valo
2021-10-20 9:46 ` Pkshih [this message]
2021-10-20 10:03 ` Kalle Valo
2021-10-21 1:34 ` Pkshih
2021-10-21 3:10 ` CGEL
2021-10-21 4:20 ` [PATCH V2] " cgel.zte
2021-10-21 5:22 ` Pkshih
2021-10-27 7:36 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3aa076f0e39a485ca090f8c14682b694@realtek.com \
--to=pkshih@realtek.com \
--cc=cgel.zte@gmail.com \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lv.ruyi@zte.com.cn \
--cc=netdev@vger.kernel.org \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).