Re: [PATCH RFC wireless-next 02/13] wifi: ieee80211: Add UHR (802.11bn) definitions

[Karthikeyan Kathirvel <karthikeyan.kathirvel@oss.qualcomm.com>]

On 12/16/2025 2:38 PM, Johannes Berg wrote:
> On Tue, 2025-12-16 at 11:56 +0530, Karthikeyan Kathirvel wrote:
>>
>> +/**
>> + * struct ieee80211_uhr_mcs_nss_supp_20mhz_only - UHR 20 MHz only station max
>> + * supported NSS for per MCS.
> 
> I think I'd rename this? Due to
> 
>> + * As per spec P802.11bn_D1.0 38.3.11 - "UHR-MCS 0-15 are the same as
>> + * EHT-MCS 0-15"
> 
> it will only ever be used for basic UHR MCSes.
>
Noted.

>> +#define IEEE80211_UHR_DBE_CAP_MAX_BW			GENMASK(2, 0)
>> +#define IEEE80211_UHR_DBE_CAP_EHT_MCS_BW_160MHZ_PRES	BIT(3)
>> +#define IEEE80211_UHR_DBE_CAP_EHT_MCS_BW_320MHZ_PRES	BIT(4)
>> +#define IEEE80211_UHR_DBE_CAP_RESERVED			GENMASK(7, 5)
>> +#define IEEE80211_UHR_DBE_CAP_EHT_MCS_BW_160MHZ		GENMASK(31, 8)
>> +#define IEEE80211_UHR_DBE_CAP_EHT_MCS_BW_320MHZ		GENMASK(55, 32)
> 
> For the record, I'm not a huge fan of GENMASK(), I tend to think just
> hex is more readable :-)
> 
> Here, using GENMASK() is also wrong for the last one of those, and it's
> really not obvious.
> 
> 
Sure, I will change it to hex format. Last bit mask is fine right it is 
from B32 - B55, what is wrong here ?
>> +/**
>> + * struct ieee80211_uhr_operation_info - uhr operation information
> 
> nit: "UHR" (throughout)
> 
> johannes
Sure, will address it