From: Jeff Johnson <jeff.johnson@oss.qualcomm.com>
To: Baochen Qiang <baochen.qiang@oss.qualcomm.com>,
Alexander Wilhelm <alexander.wilhelm@westermo.com>,
Jeff Johnson <jjohnson@kernel.org>
Cc: linux-wireless@vger.kernel.org, ath12k@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] wifi: ath12k: fix scan command endianness on big endian
Date: Sun, 12 Jul 2026 14:19:55 -0700 [thread overview]
Message-ID: <3c02ccfc-7e3d-474d-9ab5-a6b5ae187fa8@oss.qualcomm.com> (raw)
In-Reply-To: <afbff608-a005-43c4-af76-968a58bf0cc3@oss.qualcomm.com>
On 7/3/2026 1:18 AM, Baochen Qiang wrote:
> On 7/3/2026 3:35 PM, Alexander Wilhelm wrote:
>> @@ -2795,7 +2799,7 @@ int ath12k_wmi_send_scan_start_cmd(struct ath12k *ar,
>> hint_bssid = ptr;
>> for (i = 0; i < arg->num_hint_bssid; ++i) {
>> hint_bssid->freq_flags =
>> - arg->hint_bssid[i].freq_flags;
>> + cpu_to_le32(arg->hint_bssid[i].freq_flags);
>> ether_addr_copy(&arg->hint_bssid[i].bssid.addr[0],
>> &hint_bssid->bssid.addr[0]);
>
> the src and dst are wrongly swapped, should be
>
> ether_addr_copy(&hint_bssid->bssid.addr[0], &arg->hint_bssid[i].bssid.addr[0]);
>
> However since this is a pre-exising issue and not related to endian handling, not sure if
> we should fix it as well in the same patch.
>
> Jeff, your thought?
Fixing this should be a separate patch since this is an existing issue that is
unrelated to endian handling.
I already have an AI agent fired up to verify the issue so I'll have it
generate the patch.
/jeff
next prev parent reply other threads:[~2026-07-12 21:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-03 7:35 [PATCH v2] wifi: ath12k: fix scan command endianness on big endian Alexander Wilhelm
2026-07-03 7:46 ` Baochen Qiang
2026-07-03 8:18 ` Baochen Qiang
2026-07-12 21:19 ` Jeff Johnson [this message]
2026-07-16 17:12 ` Rameshkumar Sundaram
2026-07-17 15:06 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3c02ccfc-7e3d-474d-9ab5-a6b5ae187fa8@oss.qualcomm.com \
--to=jeff.johnson@oss.qualcomm.com \
--cc=alexander.wilhelm@westermo.com \
--cc=ath12k@lists.infradead.org \
--cc=baochen.qiang@oss.qualcomm.com \
--cc=jjohnson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox