From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from sabertooth01.qualcomm.com ([65.197.215.72]:13093 "EHLO sabertooth01.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162173AbbKTR7c convert rfc822-to-8bit (ORCPT ); Fri, 20 Nov 2015 12:59:32 -0500 From: "Li, Yanbo" To: "Shajakhan, Mohammed Shafi (Mohammed Shafi)" , "Valo, Kalle" CC: "linux-wireless@vger.kernel.org" , "ath10k@lists.infradead.org" Subject: RE: [PATCH] ath10k: Adjust the RX packet pad offset at QCA99X0 4addr mode Date: Fri, 20 Nov 2015 17:59:27 +0000 Message-ID: <3d283d4cea8a45fd8717ad5848626f3c@nasanexm02e.na.qualcomm.com> (sfid-20151120_185936_139610_75D86D9C) References: <1445575816-4500-1-git-send-email-yanbol@qca.qualcomm.com> <877fme40ny.fsf@kamboji.qca.qualcomm.com> <2cd04da006cb4f2a8eea859b6aad3e10@nasanexm02e.na.qualcomm.com> <87si45zmpj.fsf@kamboji.qca.qualcomm.com> <20151120133214.GA15797@shafi-laptop> In-Reply-To: <20151120133214.GA15797@shafi-laptop> Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Sender: linux-wireless-owner@vger.kernel.org List-ID: > -----Original Message----- > From: Shajakhan, Mohammed Shafi (Mohammed Shafi) > Sent: Friday, November 20, 2015 5:32 AM > To: Valo, Kalle > Cc: Li, Yanbo; linux-wireless@vger.kernel.org; ath10k@lists.infradead.org > Subject: Re: [PATCH] ath10k: Adjust the RX packet pad offset at QCA99X0 > 4addr mode > > Hi Kalle\Yanbo, > > On Mon, Nov 16, 2015 at 10:57:44PM +0200, Kalle Valo wrote: > > "Li, Yanbo" writes: > > > > >> > + /* The padding bytes's location is different on various > chips */ > > >> > + enum ath10k_loc_4addr_pad loc_4addr_pad; > > >> > > >> I think that loc prefix is a bit misleading, it reminds me of > > >> locationing/positioning etc. What about ath10k_hw_4addr_pad? > > >> > > > > > > > > > There is already a FW feature defined as > > > "ATH10K_FW_FEATURE_NO_NWIFI_DECAP_4ADDR_PADDIND" and the > relative > > > string is "no-4addr-pad", if we just remove the "loc" prefix, it may > > > be confuse with this FW feature. > > > > > > How about we change the loc to offset in this case or any better > suggestion? > > > > I did some naming changes in the pending branch: > > > > https://git.kernel.org/cgit/linux/kernel/git/kvalo/ath.git/commit/?h=p > > ending&id=42cd3832cd7c78bfeabb639a4086c7838fda5b57 > > > > Please review and let me know what you think. Looks good to me, thanks Kalle. BR /Yanbo