From: Johannes Berg <johannes@sipsolutions.net>
To: Yogesh Gaur <yogesh.gaur@intel.com>,
miriam.rachel.korenblit@intel.com,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: emmanuel.grumbach@intel.com
Subject: Re: [PATCH iwlwifi-next] wifi: iwlwifi: pcie: return a real errno from read_config32()
Date: Wed, 14 Oct 2026 14:55:35 +0200 [thread overview]
Message-ID: <3d2fde6558449d82dec7c9eef8cb4c6e4e464dc8.camel@sipsolutions.net> (raw)
In-Reply-To: <20261014124357.2569535-1-yogesh.gaur@intel.com>
On Wed, 2026-10-14 at 18:13 +0530, Yogesh Gaur wrote:
> pci_read_config_dword() can also return a positive PCIBIOS_* error code
> (e.g. PCIBIOS_DEVICE_NOT_FOUND for a disconnected device), but
> iwl_trans_pcie_read_config32() passes it through unchanged and
> iwl_dump_ini_config_iter() only checks for ret < 0. The error is missed,
> so the loop keeps reading and stores 0xffffffff in the dump.
>
> Convert the return value with pcibios_err_to_errno().
>
This isn't incorrect, but is it a good idea? I'm not convinced, we might
still get some other parts of the dump vs. just aborting the entire
section at that point?
IOW, _why_ are you doing this? Do you have a problem with it? What is
that problem? Is it just a static checker/LLM complaint that you want to
fix?
johannes
next prev parent reply other threads:[~2026-10-14 12:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 12:43 [PATCH iwlwifi-next] wifi: iwlwifi: pcie: return a real errno from read_config32() Yogesh Gaur
2026-10-14 12:55 ` Johannes Berg [this message]
2026-10-14 13:10 ` Gaur, Yogesh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3d2fde6558449d82dec7c9eef8cb4c6e4e464dc8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=emmanuel.grumbach@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=miriam.rachel.korenblit@intel.com \
--cc=yogesh.gaur@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox