Re: [PATCH v2 1/2] wifi: cfg80211/mac80211: Add support to rx retry stats

Johannes Berg
2024-03-25T15:43:43Z

On Tue, 2024-03-19 at 19:15 +0530, Hari Chandrakanthan wrote:
> Add support to count station level rx retries.

Should the subject say "for ... stats"?

> +++ b/net/mac80211/sta_info.c
> @@ -2653,6 +2653,11 @@ void sta_set_sinfo(struct sta_info *sta, struct station_info *sinfo,
> sinfo->filled |= BIT_ULL(NL80211_STA_INFO_TX_RETRIES);
> }
>
> + if (!(sinfo->filled & BIT_ULL(NL80211_STA_INFO_RX_RETRIES))) {
> + sinfo->rx_retries = sta->deflink.rx_stats.rx_retries;
> + sinfo->filled |= BIT_ULL(NL80211_STA_INFO_RX_RETRIES);
> + }

The use of deflink here seems ... questionable?

I know we've not really done any stats properly here for link STA
(patches welcome), but I guess this could be a first one that at least
sums up all the links like all of these should, and then find a way to
expose per-link as well?

Although possibly we should just expose per-link to cfg80211, and then
have cfg80211 sum up for the MLD representation...

Either way, seems odd to add something now that absolutely cannot work
for MLO?

johannes