From: Johannes Berg <johannes@sipsolutions.net>
To: Tejun Heo <tj@kernel.org>
Cc: linux-wireless@vger.kernel.org,
Lai Jiangshan <jiangshanlai@gmail.com>,
Benjamin Berg <benjamin@sipsolutions.net>
Subject: Re: wireless locking simplifications
Date: Wed, 10 May 2023 13:11:54 +0200 [thread overview]
Message-ID: <3fc1b7605f6a5e66184cb02781b3eba3e82e9ae9.camel@sipsolutions.net> (raw)
In-Reply-To: <12d77a1427cb4c0888783d8544772e3c2d1a8908.camel@sipsolutions.net>
On Wed, 2023-05-10 at 12:58 +0200, Johannes Berg wrote:
> Hi Tejun,
>
> > There isn't currently but workqueue already does something similar for
> > freezing by temporarily setting max_active to zero, so if you apply a patch
> > like the following
>
> Thanks for that! I came up with a bit of a different patch, see below.
>
But ... this raises another interesting thing.
Now I have to call workqueue_resume() somewhere. But that means I need
two versions of wiphy_unlock(), one that does the resume and one that
doesn't, which is interesting. I can track it I think though.
This is probably a stretch ;-) But what would you think about a
workqueue variant that gets a mutex pointer to hold for all work
structs? Then we'd not really have to worry about that in each of them.
But it's not great to implement, I just tried a bit.
johannes
next prev parent reply other threads:[~2023-05-10 11:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-05 21:05 wireless locking simplifications Johannes Berg
2023-05-05 21:51 ` Tejun Heo
2023-05-08 16:06 ` Johannes Berg
2023-05-10 10:58 ` Johannes Berg
2023-05-10 11:11 ` Johannes Berg [this message]
2023-05-10 11:25 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3fc1b7605f6a5e66184cb02781b3eba3e82e9ae9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=benjamin@sipsolutions.net \
--cc=jiangshanlai@gmail.com \
--cc=linux-wireless@vger.kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox