Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Nick Kossifidis" <mickflemm@gmail.com>
To: "Luis R. Rodriguez" <mcgrof@gmail.com>
Cc: "John Linville" <linville@tuxdriver.com>,
	linux-wireless@vger.kernel.org,
	"Jiri Slaby" <jirislaby@gmail.com>,
	ath5k-devel@lists.ath5k.org
Subject: Re: [PATCH] ath5k: Set ACK to user lower bit rates
Date: Fri, 2 Nov 2007 23:25:37 +0200	[thread overview]
Message-ID: <40f31dec0711021425y4e4bee5bi1c63ea165e6ed6a7@mail.gmail.com> (raw)
In-Reply-To: <40f31dec0711021413u397f9cb9r99ef8b9ca51ea01c@mail.gmail.com>

2007/11/2, Nick Kossifidis <mickflemm@gmail.com>:
> 2007/11/2, Luis R. Rodriguez <mcgrof@gmail.com>:
> > Sorry, forgot this last hunk in my patch series... This applies on top
> > of my series.
> >
> > This sets the ACK bitrate to the lower rates. Without this I get
> > about 70% packet loss when using the 11M rate. Not sure exactly what rates
> > this is setting the HW to send the ACKs in but it sure does help.
> >
>
> 6Mbits for OFDM (have checked it out with various sniffers), if not
> set i usualy get 24Mbits for acks when transmiting on 54Mbit.
>
> Haven't checked it for CCK but i guess it's 1 or 2 Mbits, have a look
> at my comments inside reg.h...
>
> #define AR5K_STA_ID1_ACKCTS_6MB         0x01000000      /* Use 6Mbit/s
> for ACK/CTS (?) */
> #define AR5K_STA_ID1_BASE_RATE_11B      0x02000000      /* Use 11b
> base rate (for ACK/CTS ?) [5211+] */
>

Also note that setting these bits is safe and cause a more stable
behaviour. If these bits are not set then control_rate is being used
(check out rate tables -remember these tables are hardcoded in hal,
that's why they have put control_rate there, to let us know what rate
is being used for ack/cts frames by hw-).

Here it is...
(transmision rate) -> (ack/cts rate)

OFDM
6 - 12 -> 6
12 - 24 -> 12
24 - 54 -> 24

CCK
1 - 2 -> 1
2 - 11 -> 2

So it still doesn't make sense that you had 70% loss, i mean any rate
between 2 and 11Mbits would cause the same ack rate (2Mbits), even if
you didn't set that bit.

-- 
GPG ID: 0xD21DB2DB
As you read this post global entropy rises. Have Fun ;-)
Nick

  reply	other threads:[~2007-11-02 21:25 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-02 20:46 [PATCH] ath5k: Set ACK to user lower bit rates Luis R. Rodriguez
2007-11-02 21:13 ` Nick Kossifidis
2007-11-02 21:25   ` Nick Kossifidis [this message]
2007-11-02 21:39     ` Luis R. Rodriguez
2007-11-02 22:19       ` Nick Kossifidis
2007-11-03  2:48         ` Luis R. Rodriguez

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40f31dec0711021425y4e4bee5bi1c63ea165e6ed6a7@mail.gmail.com \
    --to=mickflemm@gmail.com \
    --cc=ath5k-devel@lists.ath5k.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=mcgrof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox