linux-wireless.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hin-Tak Leung <hintak_leung@yahoo.co.uk>
To: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Cc: linux-wireless@vger.kernel.org, Larry Finger <Larry.Finger@lwfinger.net>
Subject: throughput problem/bisect with rtl8187B
Date: Tue, 11 Nov 2008 08:39:40 +0000 (GMT)	[thread overview]
Message-ID: <41448.77528.qm@web23104.mail.ird.yahoo.com> (raw)
In-Reply-To: <200811101936.49887.herton@mandriva.com.br>

Hi Herton,

I bisected through recent wireless-testing, and found the commit which results in my throughput problem - it is one of yours :-(. Can you and also possibly Larry give this a try: transfering some large files (>50MB) before and after reverting this particular commit, and see what sftp says about the transfer rate? You need to let sftp keep going for a while to see what rate it settles at. (>50MB should do, so a kernel source tarball
would be appropriate). The difference is quite obvious in my case - 
<60kB/s, and 7x - 10x that if I revert this commit. 

The commit is all magic numbers, so if you see the problem, can you please
have a look and check the numbers?

Thanks,
Hin-Tak 

-------------
>From 9c1493477380e51d152a2e0ef560291d7445e9ea Mon Sep 17 00:00:00 2001
From: Herton Ronaldo Krzesinski <herton@mandriva.com.br>
Date: Mon, 13 Oct 2008 18:11:00 +0000
Subject: [PATCH] rtl8187: add short slot handling for 8187B

This change adds short slot handling for 8187B variant of rtl8187 chips.
Some things to note about changes done:
* Values used are chosen to met 802.11-2007 spec. This raised a question
  about SIFS value used with 8187L: 0x22 (34) doesn't match any spec
  value. For now just don't change 8187L, but is something to be
  looked at.
* On 8187B, the location of EIFS register is at the same place as BRSR+1
  of struct rtl818x_csr. Unfortunately there is no clean way to
  accomodate 8187B differences currently, just use address of BRSR+1 and
  comment about it. The same thing happens for Ack timeout register,
  that is on CARRIER_SENSE_COUNTER location of 8187L. The eifs and ack
  timeout values are in units of 4us. All these registers information
  was gathered from references being the vendor gpl driver and 8180
  datasheet, unfortunately there is no information about this on 8187B
  datasheet. Also the ack timeout value was inspired by the same
  calculation as done on rt2x00.
-----------------


      

  parent reply	other threads:[~2008-11-11  8:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-09  6:01 throughput problem Re: [RFC/RFT PATCH v2 2/2] rtl8187: feedback transmitted packets using tx close descriptor for 8187B Hin-Tak Leung
2008-11-10 21:36 ` Herton Ronaldo Krzesinski
2008-11-10 21:55   ` Hin-Tak Leung
2008-11-11  8:39   ` Hin-Tak Leung [this message]
2008-11-11 13:10     ` throughput problem/bisect with rtl8187B Herton Ronaldo Krzesinski
2008-11-11 16:48       ` Hin-Tak Leung
2008-11-11 17:01         ` Larry Finger
2008-11-11 17:17           ` Hin-Tak Leung
2008-11-11 18:34         ` Herton Ronaldo Krzesinski
2008-11-11 19:42           ` Larry Finger
2008-11-12  1:12           ` Hin-Tak Leung
2008-11-12 19:10             ` Herton Ronaldo Krzesinski
2008-11-12 21:35               ` Larry Finger
2008-11-13  0:06                 ` Hin-Tak Leung
2008-11-13 15:40                   ` Herton Ronaldo Krzesinski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41448.77528.qm@web23104.mail.ird.yahoo.com \
    --to=hintak_leung@yahoo.co.uk \
    --cc=Larry.Finger@lwfinger.net \
    --cc=herton@mandriva.com.br \
    --cc=linux-wireless@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).