From: Sven Eckelmann <sven@narfation.org>
To: Jeff Johnson <quic_jjohnson@quicinc.com>,
ath12k@lists.infradead.org, Wen Gong <quic_wgong@quicinc.com>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH v2] wifi: ath12k: Fix buffer overflow when scanning with extraie
Date: Thu, 10 Aug 2023 10:09:25 +0200 [thread overview]
Message-ID: <4161316.1IzOArtZ34@ripper> (raw)
In-Reply-To: <db119d06-7549-3be9-524f-327485d34da9@quicinc.com>
[-- Attachment #1: Type: text/plain, Size: 1127 bytes --]
On Thursday, 10 August 2023 06:31:02 CEST Wen Gong wrote:
> On 8/10/2023 2:16 AM, Jeff Johnson wrote:
> > On 8/9/2023 10:31 AM, Jeff Johnson wrote:
> >> On 8/9/2023 1:12 AM, Wen Gong wrote:
> >>>
> [...]
> >>
> >> Reviewed-by: Jeff Johnson <quic_jjohnson@quicinc.com>
> >
> > Wen, can you please add a Fixes: tag since based upon the discussion
> > you actually observed a crash
> >
> Jeff, do you mean I should add the crash call stack or other thing in
> this patch?
I think a reference to the commit which is fixed should be added.
> The crash is observed by Sven Eckelmann <sven@narfation.org> on 07 Dec
> 2021 here:
> Subject: Re: [PATCH] ath11k: enable
> IEEE80211_HW_SINGLE_SCAN_ON_ALL_BANDS for WCN6855
> https://lore.kernel.org/linux-wireless/3267805.el9kkjlfUZ@ripper/
This was for ath11k. See my patch for it in
https://lore.kernel.org/r/20211207142913.1734635-1-sven@narfation.org
So I doubt that it is ok to add the same backtrace for an ath12k commit.
And if I compare both patches, it looks to me that you don't handle the
params->extraie.len > 16 bit (see WMI_TLV_LEN) in ath12k.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2023-08-10 8:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 8:12 [PATCH v2] wifi: ath12k: Fix buffer overflow when scanning with extraie Wen Gong
2023-08-09 17:31 ` Jeff Johnson
2023-08-09 18:16 ` Jeff Johnson
2023-08-10 4:31 ` Wen Gong
2023-08-10 8:09 ` Sven Eckelmann [this message]
2023-08-10 8:14 ` Wen Gong
2023-08-10 8:15 ` Sven Eckelmann
2023-08-10 13:46 ` Jeff Johnson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4161316.1IzOArtZ34@ripper \
--to=sven@narfation.org \
--cc=ath12k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=quic_jjohnson@quicinc.com \
--cc=quic_wgong@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).