From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Greear <greearb@candelatech.com>, linux-wireless@vger.kernel.org
Subject: Re: [PATCH wireless-next] wifi: mac80211: check stations are removed before MLD change
Date: Tue, 05 May 2026 17:55:02 +0200 [thread overview]
Message-ID: <416a4b3cbf8bfc2fa17c14a347f31bbaf2a5376a.camel@sipsolutions.net> (raw)
In-Reply-To: <d50bc7a2-352d-43ff-b3c7-b5b13ce7112b@candelatech.com>
On Tue, 2026-05-05 at 07:17 -0700, Ben Greear wrote:
>
> > @@ -307,6 +307,9 @@ static int ieee80211_vif_update_links(struct ieee80211_sub_if_data *sdata,
> > if (old_links == new_links && dormant_links == sdata->vif.dormant_links)
> > return 0;
> >
> > + if (!old_links || !new_links)
> > + WARN_ON(sta_info_flush(sdata, -1) > 0);
>
> Maybe WARN_ON_ONCE to keep log spam to a minimum?
Maybe ... It's never really _supposed_ to happen though, and if it does
then I doubt it would happen twice, at least not in close succession,
since it flushes here. It's a trade-off between the extra state and
potential extra warnings, so not sure the _ONCE is worth it here.
johannes
prev parent reply other threads:[~2026-05-05 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-05 13:17 [PATCH wireless-next] wifi: mac80211: check stations are removed before MLD change Johannes Berg
2026-05-05 14:17 ` Ben Greear
2026-05-05 15:55 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416a4b3cbf8bfc2fa17c14a347f31bbaf2a5376a.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=greearb@candelatech.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox