From: <samuel@sortiz.org>
To: Tomas Winkler <tomasw@gmail.com>
Cc: "Johannes Berg" <johannes@sipsolutions.net>,
"John W. Linville" <linville@tuxdriver.com>,
"Miguel Botón" <mboton.lkml@gmail.com>,
linux-wireless@vger.kernel.org, yi.zhu@intel.com
Subject: Re: [PATCH 1/2] mac80211: add power management support
Date: Fri, 27 Jun 2008 00:10:06 +0200 [thread overview]
Message-ID: <416e094b76d79fa1dd23afabd74ff78c@localhost> (raw)
In-Reply-To: <1ba2fa240806261451n53e5cb8an70aad7b072121c2e@mail.gmail.com>
Hi Thomas=0D
=0D
On Fri, 27 Jun 2008 00:51:57 +0300, "Tomas Winkler" <tomasw@gmail.com>=0D
wrote:=0D
> On Thu, Jun 26, 2008 at 9:23 PM, Johannes Berg=0D
> <johannes@sipsolutions.net> wrote:=0D
>> On Thu, 2008-06-26 at 13:55 -0400, John W. Linville wrote:=0D
>>> On Thu, Jun 26, 2008 at 07:40:58PM +0200, Samuel Ortiz wrote:=0D
>>> > Hi John,=0D
>>> >=0D
>>> > On Fri, Nov 16, 2007 at 07:53:26PM +0100, Miguel Bot=C3=B3n wrote=
:=0D
>>> > > Ok, the previous patch had a little error.=0D
>>> > >=0D
>>> > > --=0D
>>> > >=0D
>>> > > This patch adds power management support in mac80211.=0D
>>> > Sorry for being late to the game, but would a similar patch again=
st=0D
> your=0D
>>> > -next-2.6 tree be considered for inclusion ?=0D
>>>=0D
>>> It seems like a reasonable start to me. Anyone else have comments?=
=0D
>>=0D
>> I had one about it returning -EINVAL for all errors that was never=0D
>> addressed afaict.=0D
> =0D
> Didn't Yi submitted this one like year ago and rejected?=0D
I searched through the mailing list, but couldnt find anything else=0D
than this patch.=0D
=0D
=0D
> This is why we have currently implemented in iwlwif sysfs.=0D
> =0D
> /sys/class/net/wlanX/devices/power_level=0D
> there are defined 6 power levels=0D
> 0 - CAM mode (Continuous Aware Mode)=0D
> 6 - AUTO=0D
> 1 to 5 levels that specifies power save aggressiveness empirically=0D
> developed.=0D
> AUTO - depends on system power source/level=0D
> system power level is AC or BATTERY - currently we do not have=0D
> anything that tells us whether we run on battery or ac.=0D
> Other factor is association state.=0D
> =0D
> This can be expressed as=0D
> iwconfig power saving 1..5=0D
> iwconfig power off - > CAM mode=0D
> iwconfig power auto - this is unfortunately not defined by iwconfig=0D
> =0D
> If this acceptable we can submit the patch=0D
Are you talking about the wext patch, or the sysfs one ?=0D
I'd definitely be happy to have a look at the wext one.=0D
=0D
Cheers,=0D
Samuel.
--
To unsubscribe from this list: send the line "unsubscribe linux-wireles=
s" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2008-06-26 22:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-16 18:29 [PATCH 1/2] mac80211: add power management support Miguel Botón
2007-11-16 18:53 ` Miguel Botón
2007-11-16 19:02 ` Miguel Botón
2007-11-16 21:13 ` Johannes Berg
2008-06-26 17:40 ` Samuel Ortiz
2008-06-26 17:55 ` John W. Linville
2008-06-26 18:23 ` Johannes Berg
2008-06-26 21:51 ` Tomas Winkler
2008-06-26 22:10 ` samuel [this message]
2008-06-27 4:14 ` Kalle Valo
2008-07-04 8:49 ` [PATCH] mac80211: power management wext hooks (was [PATCH 1/2] mac80211: add power management support) Samuel Ortiz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=416e094b76d79fa1dd23afabd74ff78c@localhost \
--to=samuel@sortiz.org \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mboton.lkml@gmail.com \
--cc=tomasw@gmail.com \
--cc=yi.zhu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).