RE: [PATCH rtw-next] wifi: rtw88: 8723b: Read the package type from efuse

[Ping-Ke Shih <pkshih@realtek.com>]

Bitterblue Smith <rtl8821cerfe2@gmail.com> wrote:

[...]

> +static void rtw8723b_read_package_type(struct rtw_dev *rtwdev)
> +{
> +       struct rtw_hal *hal = &rtwdev->hal;
> +       u8 val_1fb;
> +
> +       rtw8723b_efuse_grant(rtwdev, true);
> +       rtw_read8_physical_efuse(rtwdev, 0x1fb, &val_1fb);
> +       rtw8723b_efuse_grant(rtwdev, false);

In rtw_parse_efuse_map(), we can pass 'phy_map' to read_efuse()?
-chip->ops->read_efuse(rtwdev, log_map);
+chip->ops->read_efuse(rtwdev, log_map, phy_map);

As .phy_efuse_size = 512 for RTL7823B, I think it will work. 

> +
> +       switch (u8_get_bits(val_1fb, GENMASK(2, 0))) {

Bit 2~0 seems like PKG_TYPE. Define an enum?

> +       case 0x4:
> +               hal->pkg_type = RTW8723B_PACKAGE_TFBGA79;
> +               break;
> +       case 0x5:
> +               hal->pkg_type = RTW8723B_PACKAGE_TFBGA90;
> +               break;
> +       case 0x6:
> +               hal->pkg_type = RTW8723B_PACKAGE_QFN68;
> +               break;
> +       case 0x7:
> +               hal->pkg_type = RTW8723B_PACKAGE_TFBGA80;
> +               break;
> +       default:
> +               hal->pkg_type = RTW8723B_PACKAGE_DEFAULT;
> +               break;
> +       }
> +
> +       if (rtw_hci_type(rtwdev) == RTW_HCI_TYPE_SDIO &&
> +           u8_get_bits(val_1fb, GENMASK(5, 4)) == 0x2)

Can you define enums for bit 5-4 and value 0x2?
I'm not sure if vendor driver has some comments pointing out this or not.

> +               rtwdev->efuse.hw_cap.bw &= ~BIT(RTW_CHANNEL_WIDTH_40);
> +}
> +
>  static int rtw8723b_read_efuse(struct rtw_dev *rtwdev, u8 *log_map)
>  {
>         struct rtw_efuse *efuse = &rtwdev->efuse;