From: Aditya Garg <aditya.garg@linux.dev>
To: Jason Perlow <jperlow@gmail.com>,
Arend van Spriel <arend.vanspriel@broadcom.com>,
Baolu Lu <baolu.lu@linux.intel.com>,
dwmw2@infradead.org
Cc: iommu@lists.linux.dev, Bjorn Helgaas <bhelgaas@google.com>,
linux-pci@vger.kernel.org, linux-wireless@vger.kernel.org,
johannes@sipsolutions.net
Subject: Re: intel-iommu: DMAR PTE Read fault crash-loops a PCIe wifi device, v7.3-rc7 -> v7.3 final regression, reproduces on one unit out of five tested
Date: Wed, 21 Oct 2026 22:57:54 +0530 [thread overview]
Message-ID: <428ba501-e6ce-4be1-b4cd-adaba4c0c12a@linux.dev> (raw)
In-Reply-To: <20F90036-F53C-4490-B27A-DFD055DB22E8@gmail.com>
On 10/21/26 10:34 PM, Jason Perlow wrote:
>
>
>
>>
>> I would prefer the above in proper patch, but it's up to Johannes.
>>
>> Regards,
>> Arend
>>
>>
>>
> Patch below.
>
> -- >8 --
> Subject: [PATCH] wifi: brcmfmac: map msgbuf RX packet IDs bidirectional
>
> Commit f0ba5fd51ff2 ("wifi: brcmfmac: Set DMA direction for msgbuf
> packet IDs") maps the RX packet ID buffers DMA_FROM_DEVICE. The
> BCM4364 firmware also reads posted RX buffers, so with VT-d
> translation enabled every such read faults ("PTE Read access is not
> set") and the firmware crashes and resets in a loop.
>
> Map the RX pool DMA_BIDIRECTIONAL again, as before that commit. TX
> keeps DMA_TO_DEVICE.
>
> Fixes: f0ba5fd51ff2 ("wifi: brcmfmac: Set DMA direction for msgbuf packet IDs")
> Cc: stable@vger.kernel.org
> Tested-by: Jason Perlow <jperlow@gmail.com>
> Signed-off-by: Jason Perlow <jperlow@gmail.com>
> ---
> drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
> index 069ba70..ff47d48 100644
> --- a/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
> +++ b/drivers/net/wireless/broadcom/brcm80211/brcmfmac/msgbuf.c
> @@ -1639,7 +1639,7 @@ int brcmf_proto_msgbuf_attach(struct brcmf_pub *drvr)
> if (!msgbuf->tx_pktids)
> goto fail;
> msgbuf->rx_pktids = brcmf_msgbuf_init_pktids(NR_RX_PKTIDS,
> - DMA_FROM_DEVICE);
> + DMA_BIDIRECTIONAL);
> if (!msgbuf->rx_pktids)
> goto fail;
>
I've submitted this patch properly here:
https://lore.kernel.org/linux-wireless/20261021172238.10004-1-aditya.garg@linux.dev/T/#u
next prev parent reply other threads:[~2026-10-21 17:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CABZrw2GfC8SEPiGOUD42um57nKZAghjHz8N1DhMsw8sOC7OAxA@mail.gmail.com>
2026-10-20 14:46 ` intel-iommu: DMAR PTE Read fault crash-loops a PCIe wifi device, v7.3-rc7 -> v7.3 final regression, reproduces on one unit out of five tested Aditya Garg
2026-10-21 6:13 ` Baolu Lu
2026-10-21 7:33 ` Jason Perlow
2026-10-21 8:39 ` Arend van Spriel
2026-10-21 13:53 ` Jason Perlow
2026-10-21 16:39 ` Arend van Spriel
2026-10-21 17:04 ` Jason Perlow
2026-10-21 17:27 ` Aditya Garg [this message]
2026-10-21 17:28 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=428ba501-e6ce-4be1-b4cd-adaba4c0c12a@linux.dev \
--to=aditya.garg@linux.dev \
--cc=arend.vanspriel@broadcom.com \
--cc=baolu.lu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=dwmw2@infradead.org \
--cc=iommu@lists.linux.dev \
--cc=johannes@sipsolutions.net \
--cc=jperlow@gmail.com \
--cc=linux-pci@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox