From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: "Johannes Berg" <johannes@sipsolutions.net>
Cc: "Michael Buesch" <mb@bu3sch.de>,
"Michael Wu" <flamingice@sourmilk.net>,
linux-wireless@vger.kernel.org,
"John W. Linville" <linville@tuxdriver.com>
Subject: Re: [PATCH] mac80211: fix interface initialisation
Date: Tue, 25 Sep 2007 20:02:38 -0400 [thread overview]
Message-ID: <43e72e890709251702q27bbfa5eoe65a626ced383dd6@mail.gmail.com> (raw)
In-Reply-To: <1190755892.18521.330.camel@johannes.berg>
On 9/25/07, Johannes Berg <johannes@sipsolutions.net> wrote:
> --- wireless-dev.orig/net/mac80211/ieee80211_iface.c 2007-09-25 22:26:40.111572537 +0200
> +++ wireless-dev/net/mac80211/ieee80211_iface.c 2007-09-25 23:28:21.651570910 +0200
> @@ -127,6 +127,12 @@ int ieee80211_if_add_mgmt(struct ieee802
> if (ret)
> goto fail;
>
> + /*
> + * Called even when register_netdevice fails, it would
> + * oops if assigned before initialising the rest.
> + */
> + ndev->uninit = ieee80211_if_reinit;
> +
> ieee80211_debugfs_add_netdev(nsdata);
>
> if (local->open_count > 0)
What still uses ieee80211_if_add_mgmt()? I don't see anything using
it. Also, did we decide on what to do with IEEE80211_IF_TYPE_MGMT?
Luis
next prev parent reply other threads:[~2007-09-26 0:02 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-25 20:06 mac80211: crash while adding interface Michael Buesch
2007-09-25 20:36 ` Johannes Berg
2007-09-25 20:45 ` Johannes Berg
2007-09-25 21:31 ` [PATCH] mac80211: fix interface initialisation Johannes Berg
2007-09-25 21:32 ` Michael Buesch
2007-09-25 21:44 ` Johannes Berg
2007-09-26 0:02 ` Luis R. Rodriguez [this message]
2007-09-26 7:04 ` Johannes Berg
2007-09-26 12:27 ` [PATCH v2] mac80211: fix interface initialisation and deinitialisation Johannes Berg
2007-09-26 14:37 ` Michael Buesch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e72e890709251702q27bbfa5eoe65a626ced383dd6@mail.gmail.com \
--to=mcgrof@gmail.com \
--cc=flamingice@sourmilk.net \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=mb@bu3sch.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).