Re: RTS wrong hdrlen computation?

["Luis R. Rodriguez" <mcgrof@gmail.com>]

On 10/30/07, John W. Linville <linville@tuxdriver.com> wrote:
> On Tue, Oct 30, 2007 at 12:56:39PM -0400, Luis R. Rodriguez wrote:
> > Perhaps an oversight, gotta go so can't keep looking, perhaps others will know
> >
> > diff --git a/net/mac80211/util.c b/net/mac80211/util.c
> > index 27203f1..7f7da9c 100644
> > --- a/net/mac80211/util.c
> > +++ b/net/mac80211/util.c
> > @@ -188,8 +188,11 @@ int ieee80211_get_hdrlen(u16 fc)
> >                  *   subtype mask:   0b0000000011110000 (0x00F0)
> >                  *   ACK subtype:    0b0000000011010000 (0x00D0)
> >                  *   CTS subtype:    0b0000000011000000 (0x00C0)
> > +                *   RTS subtype:    0b0000000010110000 (0x00B0) **
> >                  *   bits that matter:         ^^^      (0x00E0)
> >                  *   value of those: 0b0000000011000000 (0x00C0)
> > +                *
> > +                *   Note: this doesn't work for RTS...
> >                  */
> >                 if ((fc & 0xE0) == 0xC0)
> >                         hdrlen = 10;
>
> It looks like the default case (i.e. "hdrlen = 16") is fine for RTS.
> What am I missing...?

Sorry had a bad morning, you're right..

  Luis