Re: [RFC] cfg80211: send country ie processing on the reg_work struct

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Tue, Jul 28, 2009 at 12:37 AM, Johannes
Berg<johannes@sipsolutions.net> wrote:
> On Mon, 2009-07-27 at 18:29 -0700, Luis R. Rodriguez wrote:
>> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
>> ---
>>
>> Did this in a flash, so just want to see if this is you like this
>> approach. Of course a lot of cleaning can be done here but ignore that
>> for now (like the fact that beacon hint doesn't really process IEs,
>> and the functions names used here).
>>
>> This just compiles for me, never tested it.
>
> Looks ok, but I don't see why you need this type enum?

To make it clear what type of beacon hint this is. I could have just
used an element in the struct reg_beacon but thought this would make
it more clear to the reader.

>> + * enum beacon_hint_type - type of regulatory beacon hint
>
> I mean -- if the beacon was received we could just process it as before,
> and if it also has a country IE we can just process that additionally?
> Why bother doing both separately?

I agree with you but this is different than addressing just the
lockdep warning and I wasn't really planning on doing that right now,
but it seems the work required may not be that much, I'll see if I can
just do it...

  Luis