From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-iw0-f180.google.com ([209.85.223.180]:62915 "EHLO mail-iw0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755182AbZJIAP0 convert rfc822-to-8bit (ORCPT ); Thu, 8 Oct 2009 20:15:26 -0400 Received: by iwn10 with SMTP id 10so928106iwn.4 for ; Thu, 08 Oct 2009 17:14:49 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <3ace41890910081622k7c86453dm72e5584f4adbb763@mail.gmail.com> References: <3ace41890910071216y69b8bc9la67b8f0ce5890cd8@mail.gmail.com> <3ace41890910071228i786d4097w69dc7a3dfeb64afe@mail.gmail.com> <1254952886.3713.4.camel@johannes.local> <3ace41890910072328n1460ee34v1fe7ca9b78eb646f@mail.gmail.com> <1254995514.3713.22.camel@johannes.local> <1255002647.3713.25.camel@johannes.local> <43e72e890910080643h282c4bf1xf972f15f13eae755@mail.gmail.com> <3ace41890910081622k7c86453dm72e5584f4adbb763@mail.gmail.com> From: "Luis R. Rodriguez" Date: Thu, 8 Oct 2009 20:14:28 -0400 Message-ID: <43e72e890910081714u7e1d2168u98c0ccb74915c94c@mail.gmail.com> Subject: Re: NULL pointer deref at wext ioctl (Re: [PATCH] compat-2.6: adding ethtool.h to compat-2.6.31.h) To: Hin-Tak Leung Cc: Johannes Berg , "John W. Linville" , linux-wireless@vger.kernel.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Thu, Oct 8, 2009 at 7:22 PM, Hin-Tak Leung wrote: > On Thu, Oct 8, 2009 at 2:43 PM, Luis R. Rodriguez > wrote: >> On Thu, Oct 8, 2009 at 7:50 AM, Johannes Berg wrote: >>> On Thu, 2009-10-08 at 11:51 +0200, Johannes Berg wrote: >>> >>>> Ok, that's odd. Is it possible that somehow cfg80211 is picking up an >>>> #ifdef'ed copy of "struct iw_handler_def", and thus the struct it is >>>> defining is simply too small? >>> >>> That is apparently what is happening since compat-wireless ships >>> iw_handler.h. This is wrong, as wext functionality is built into the >>> kernel image so you can't use a newer header file with it. >> >> Dah, thanks for looking into this! This must've been there this way >> for ages and we hadn't noticed until now. This is now fixed, and a new >> tarball pushed out. I'll fix on the stable stuff as well, although I >> doubt the header has changed much except now. >> >>  Luis >> > > Thanks everybody! Works alright now, after 'compat-2.6: stop shipping > bleeding edge iw_handler.h' . > > There are some harmless warnings from using the old header, but > otherwise it is working as it should: >  CC [M]  /home/Hin-Tak/tmp-git/compat-wireless-2.6/net/wireless/sme.o > /home/Hin-Tak/tmp-git/compat-wireless-2.6/net/wireless/sme.c: In > function ‘__cfg80211_connect_result’: > /home/Hin-Tak/tmp-git/compat-wireless-2.6/net/wireless/sme.c:370: > warning: passing argument 4 of ‘wireless_send_event’ discards > qualifiers from pointer target type > include/net/iw_handler.h:443: note: expected ‘char *’ but argument is > of type ‘const u8 *’ > /home/Hin-Tak/tmp-git/compat-wireless-2.6/net/wireless/sme.c:376: > warning: passing argument 4 of ‘wireless_send_event’ discards > qualifiers from pointer target type > include/net/iw_handler.h:443: note: expected ‘char *’ but argument is > of type ‘const u8 *’ > /home/Hin-Tak/tmp-git/compat-wireless-2.6/net/wireless/sme.c: In > function ‘__cfg80211_roamed’: > /home/Hin-Tak/tmp-git/compat-wireless-2.6/net/wireless/sme.c:520: > warning: passing argument 4 of ‘wireless_send_event’ discards > qualifiers from pointer target type > include/net/iw_handler.h:443: note: expected ‘char *’ but argument is > of type ‘const u8 *’ > /home/Hin-Tak/tmp-git/compat-wireless-2.6/net/wireless/sme.c:527: > warning: passing argument 4 of ‘wireless_send_event’ discards > qualifiers from pointer target type > include/net/iw_handler.h:443: note: expected ‘char *’ but argument is > of type ‘const u8 *’ The last argument to wireless_send_event() was changed to be const on 2.6.32, cant think of a way to avoid this warning. Luis