Re: [PATCH 2/4] ath9k_hw: distinguish single-chip solutions on initial probe print

["Luis R. Rodriguez" <lrodriguez@atheros.com>]

On Mon, Oct 26, 2009 at 9:14 AM, Kalle Valo <kalle.valo@iki.fi> wrote:
> "Luis R. Rodriguez" <lrodriguez@atheros.com> writes:
>
>> Devices with external radios have revisions which we can count on.
>> On single chip solutions these EEPROM values for these radio revision
>> also exist but are not meaningful as the radios are embedded onto the
>> same chip. Each single-chip device evolves together as one device.
>>
>> Signed-off-by: Luis R. Rodriguez <lrodriguez@atheros.com>
>> ---
>>  drivers/net/wireless/ath/ath9k/ahb.c |   11 ++++-------
>>  drivers/net/wireless/ath/ath9k/hw.c  |   27 +++++++++++++++++++++++----
>>  drivers/net/wireless/ath/ath9k/hw.h  |    3 +--
>>  drivers/net/wireless/ath/ath9k/pci.c |   11 ++++-------
>>  4 files changed, 32 insertions(+), 20 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/ahb.c b/drivers/net/wireless/ath/ath9k/ahb.c
>> index 41422c4..925818c 100644
>> --- a/drivers/net/wireless/ath/ath9k/ahb.c
>> +++ b/drivers/net/wireless/ath/ath9k/ahb.c
>> @@ -69,6 +69,7 @@ static int ath_ahb_probe(struct platform_device *pdev)
>>       int irq;
>>       int ret = 0;
>>       struct ath_hw *ah;
>> +     char hw_name[1024];
>
> This is a bit too large to allocate from stack IMHO.
>
>
> [...]
>
>> --- a/drivers/net/wireless/ath/ath9k/pci.c
>> +++ b/drivers/net/wireless/ath/ath9k/pci.c
>> @@ -114,6 +114,7 @@ static int ath_pci_probe(struct pci_dev *pdev, const struct pci_device_id *id)
>>       u32 val;
>>       int ret = 0;
>>       struct ath_hw *ah;
>> +     char hw_name[1024];
>
> Ditto.

We use this for debugfs, so I went with that as an upper limit, given
that we just use it a probe it seemed sane.

  Luis