Linux wireless drivers development
 help / color / mirror / Atom feed
From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: John Linville <linville@tuxdriver.com>, Jouni Malinen <j@w1.fi>,
	linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH] cfg80211: validate scan channels
Date: Mon, 2 Nov 2009 08:42:14 -0800	[thread overview]
Message-ID: <43e72e890911020842v5a4c5129t6ffd3779a08328fc@mail.gmail.com> (raw)
In-Reply-To: <1257165123.3555.185.camel@johannes.local>

On Mon, Nov 2, 2009 at 4:32 AM, Johannes Berg <johannes@sipsolutions.net> wrote:
> Currently it is possible to request a scan on only
> disabled channels, which could be problematic for
> some drivers. Reject such scans, and also ignore
> disabled channels that are given. This resuls in
> the scan begin/end event only including channels
> that are actually used.
>
> This makes the mac80211 check for disabled channels
> superfluous. At the same time, remove the no-IBSS
> check from mac80211 -- nothing says that we should
> not find any networks on channels that cannot be
> used for an IBSS, even when operating in IBSS mode.
>
> Signed-off-by: Johannes Berg <johannes@sipsolutions.net>

Side note that this patch reminds me of.

About two days ago I noticed that if my internal card enables channel
12 as its world roaming, I connect to my AP on channel 12 (therefore
lifting the passive scan flag), and if I then connect a USB device
which disables channel 12 communication will still go on on channel 12
on the old card but the channel will still have been marked as
disabled.

I figured I'd not here that we currently can trash these types of
connections because as noted with this patch we'd disable scanning --
but we only degrade the connection, we don't do something sensible. So
when we get a chance we should force a disconnect if a channel we're
using all of a sudden becomes disabled.

  Luis

      reply	other threads:[~2009-11-02 16:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-11-02 12:32 [PATCH] cfg80211: validate scan channels Johannes Berg
2009-11-02 16:42 ` Luis R. Rodriguez [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=43e72e890911020842v5a4c5129t6ffd3779a08328fc@mail.gmail.com \
    --to=mcgrof@gmail.com \
    --cc=j@w1.fi \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox