From: "Luis R. Rodriguez" <mcgrof@gmail.com>
To: Sujith <Sujith.Manoharan@atheros.com>, Greg KH <greg@kroah.com>
Cc: linville@tuxdriver.com, linux-wireless@vger.kernel.org,
David Woodhouse <dwmw2@infradead.org>,
stable@kernel.org
Subject: Re: [PATCH] ath9k: Fix TX hang poll routine
Date: Wed, 2 Dec 2009 09:04:03 -0800 [thread overview]
Message-ID: <43e72e890912020904v6254ca99j78ca82b528ce97cf@mail.gmail.com> (raw)
In-Reply-To: <43e72e890911240811t2e2a70a3k98ca2516ca5dc4b6@mail.gmail.com>
On Tue, Nov 24, 2009 at 8:11 AM, Luis R. Rodriguez <mcgrof@gmail.com> wrote:
> On Thu, Oct 8, 2009 at 8:21 PM, Sujith <Sujith.Manoharan@atheros.com> wrote:
>> When TX is hung, the chip is reset. Ensure that
>> the chip is awake by using the PS wrappers.
>>
>> Signed-off-by: Sujith <Sujith.Manoharan@atheros.com>
>> ---
>> drivers/net/wireless/ath/ath9k/xmit.c | 2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>>
>> diff --git a/drivers/net/wireless/ath/ath9k/xmit.c b/drivers/net/wireless/ath/ath9k/xmit.c
>> index a8620b1..2a4efcb 100644
>> --- a/drivers/net/wireless/ath/ath9k/xmit.c
>> +++ b/drivers/net/wireless/ath/ath9k/xmit.c
>> @@ -2079,7 +2079,9 @@ static void ath_tx_complete_poll_work(struct work_struct *work)
>> if (needreset) {
>> ath_print(ath9k_hw_common(sc->sc_ah), ATH_DBG_RESET,
>> "tx hung, resetting the chip\n");
>> + ath9k_ps_wakeup(sc);
>> ath_reset(sc, false);
>> + ath9k_ps_restore(sc);
>> }
>>
>> ieee80211_queue_delayed_work(sc->hw, &sc->tx_complete_work,
>> --
>
> John this should be pulled to 2.6.32 if possible. It would do the
> actual reset and fix TX properly if we are asleep.
Note: stable fix, don't recall yet if this will apply to 31 series though.
Luis
prev parent reply other threads:[~2009-12-02 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-09 4:21 [PATCH] ath9k: Fix TX hang poll routine Sujith
2009-11-24 16:11 ` Luis R. Rodriguez
2009-12-02 17:04 ` Luis R. Rodriguez [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43e72e890912020904v6254ca99j78ca82b528ce97cf@mail.gmail.com \
--to=mcgrof@gmail.com \
--cc=Sujith.Manoharan@atheros.com \
--cc=dwmw2@infradead.org \
--cc=greg@kroah.com \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox