Re: [PATCH] mac80211: delete addba_resp_timer when stop Tx BA session

["Luis R. Rodriguez" <mcgrof@gmail.com>]

On Mon, Dec 28, 2009 at 12:18 AM, Johannes Berg
<johannes@sipsolutions.net> wrote:
> On Mon, 2009-12-28 at 11:18 +0800, Zhu Yi wrote:
>> We start an one shot addba_resp_timer in ieee80211_start_tx_ba_session
>> but don't delete it in __ieee80211_stop_tx_ba_session. This will cause
>> problem in suspend and resume. When suspend happens without the timer
>> deleted, the timer handler will be called immediately after resume and
>> messes up driver status.
>>
>> See http://bugzilla.intellinuxwireless.org/show_bug.cgi?id=2134
>> comment #22 for more details.
>
> Hmm. The timer checks
>
>        if ((*state & (HT_ADDBA_REQUESTED_MSK | HT_ADDBA_RECEIVED_MSK)) !=
>                                                HT_ADDBA_REQUESTED_MSK) {
>
> which /should/ make it a no-op in the case you mention because we tear
> down sessions, or does that not reset their state properly?
>
> Ok, so ___ieee80211_stop_tx_ba_session() doesn't, in fact, clear the
> mask right away, so I think we should add HT_AGG_STATE_REQ_STOP_BA_MSK
> to the code I quoted above?

When the patch addresses the above can you cc stable if applicable.

> In any case the del_timer_sync isn't right there and we also shouldn't
> really use it (per Linus)

Why is that?

  Luis