From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pz0-f200.google.com ([209.85.222.200]:48028 "EHLO mail-pz0-f200.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750972Ab0CITeG convert rfc822-to-8bit (ORCPT ); Tue, 9 Mar 2010 14:34:06 -0500 Received: by pzk38 with SMTP id 38so1808479pzk.33 for ; Tue, 09 Mar 2010 11:34:04 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <1268161528-24028-1-git-send-email-sprecher.m@gmail.com> References: <1268161528-24028-1-git-send-email-sprecher.m@gmail.com> From: "Luis R. Rodriguez" Date: Tue, 9 Mar 2010 11:33:44 -0800 Message-ID: <43e72e891003091133h31bfb1c5sceb4d3c9258792e6@mail.gmail.com> Subject: Re: [PATCH] wireless: ath9k: Fix most coding style issues in ath9k This patch fixed up almost all coding style issues in the ath9k driver found by the ceckpatch.pl tool. Signed-off-by: Michael Sprecher To: Michael Sprecher Cc: jmalinen@atheros.com, linux-wireless@vger.kernel.org, ath9k-devel@lists.ath9k.org Content-Type: text/plain; charset=UTF-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On Tue, Mar 9, 2010 at 11:05 AM, Michael Sprecher wrote: > --- >  drivers/net/wireless/ath/ath9k/ani.c         |    5 ++- >  drivers/net/wireless/ath/ath9k/ath9k.h       |   28 ++++++++-------- >  drivers/net/wireless/ath/ath9k/beacon.c      |    6 ++-- >  drivers/net/wireless/ath/ath9k/btcoex.h      |    6 ++-- >  drivers/net/wireless/ath/ath9k/calib.c       |   15 ++++----- >  drivers/net/wireless/ath/ath9k/calib.h       |    4 +- >  drivers/net/wireless/ath/ath9k/common.c      |   20 +++++------ >  drivers/net/wireless/ath/ath9k/common.h      |   10 +++--- >  drivers/net/wireless/ath/ath9k/debug.c       |   12 +++--- >  drivers/net/wireless/ath/ath9k/eeprom.h      |    4 +- >  drivers/net/wireless/ath/ath9k/eeprom_4k.c   |   16 +++++----- >  drivers/net/wireless/ath/ath9k/eeprom_9287.c |   14 +++++--- >  drivers/net/wireless/ath/ath9k/eeprom_def.c  |   31 +++++++++--------- >  drivers/net/wireless/ath/ath9k/gpio.c        |    2 +- >  drivers/net/wireless/ath/ath9k/hw.c          |   44 +++++++++++-------------- >  drivers/net/wireless/ath/ath9k/hw.h          |   22 ++++++------ >  drivers/net/wireless/ath/ath9k/init.c        |    6 ++-- >  drivers/net/wireless/ath/ath9k/mac.h         |    2 +- >  drivers/net/wireless/ath/ath9k/main.c        |   26 +++++++------- >  drivers/net/wireless/ath/ath9k/phy.c         |   12 +++---- >  drivers/net/wireless/ath/ath9k/phy.h         |    4 +- >  drivers/net/wireless/ath/ath9k/rc.c          |   13 +++---- >  drivers/net/wireless/ath/ath9k/rc.h          |    4 +- >  drivers/net/wireless/ath/ath9k/recv.c        |    5 +-- >  drivers/net/wireless/ath/ath9k/reg.h         |   22 ++++++------ >  drivers/net/wireless/ath/ath9k/virtual.c     |    3 +- >  drivers/net/wireless/ath/ath9k/xmit.c        |   11 +++--- >  27 files changed, 167 insertions(+), 180 deletions(-) Thanks a lot! Unfortunately right now we have two large patch bombs pending integration which would likely conflict with your patch. One set which I hope we can get into 2.6.34-rc2, the ath9k_htc driver. Then after that I have an already accumulated set of patches (count is at 10 right now) for AR93xx work. The ar93xx work is not intended for 2.6.34 though so I could rebase my work on top of yours but lets first see ath9k_htc get merged first and decide then. So NACK for now. Luis