From: Aloka Dixit <alokad@codeaurora.org>
To: Arend Van Spriel <arend.vanspriel@broadcom.com>
Cc: johannes@sipsolutions.net, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v3 0/2] Add FILS discovery support
Date: Sat, 13 Jun 2020 17:47:01 -0700 [thread overview]
Message-ID: <43f3871e11a02055a6662fc6aa5cf682@codeaurora.org> (raw)
In-Reply-To: <21731442-f74f-339d-15a4-8dd18b68638a@broadcom.com>
On 2020-06-04 00:38, Arend Van Spriel wrote:
> On 6/2/2020 3:38 AM, Aloka Dixit wrote:
>> This patchset adds support for FILS discovery transmission as per
>> IEEE Std 802.11ai-2016.
>>
>> This is the next version in the series given below:
>> FILS discovery and bcast probe resp support.
>> Unsolicited broadcast probe response support is now split into
>> a separate patchset.
>
> Hi Aloka,
>
> What is your motivation for the split? As you stated earlier FILS
> discovery and unsollicited probe responses are mutual exclusive as it
> only eats up airtime to do both. I tend to agree to that earlier
> statement so I would like to see some arguments for doing the split.
>
Hi Arend,
Two reasons to split the patches:
(1) Unsolicited broadcast probe response is specific to 6GHz whereas
FILS discovery is applicable in all bands. I haven't added a check for
6GHz for the former in nl80211 and mac80211 code because I expect the
application and driver implementations to add it.
(2) IEEE P802.11ax/D6.0 mentions that a device "may" skip FILS discovery
transmission and instead schedule unsolicited broadcast probe response
(if enabled) in 6GHz, but it is not mandatory.
So it made sense to have two separate attributes and let the driver
and/or FW implementation decide if both can be active at the same time.
nl80211 and mac80211 shouldn't make that decision.
With separate attributes, having separate patches are easier to review.
> Regards,
> Arend
>
>> Aloka Dixit (2):
>> nl80211: Add FILS discovery support
>> mac80211: Add FILS discovery transmission support
>>
>> include/net/cfg80211.h | 25 ++++++++++++++++
>> include/net/mac80211.h | 31 ++++++++++++++++++++
>> include/uapi/linux/nl80211.h | 46 +++++++++++++++++++++++++++++
>> net/mac80211/cfg.c | 46 +++++++++++++++++++++++++++++
>> net/mac80211/ieee80211_i.h | 7 +++++
>> net/mac80211/tx.c | 25 ++++++++++++++++
>> net/wireless/nl80211.c | 57
>> ++++++++++++++++++++++++++++++++++++
>> 7 files changed, 237 insertions(+)
>>
next prev parent reply other threads:[~2020-06-14 0:47 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-02 1:38 [PATCH v3 0/2] Add FILS discovery support Aloka Dixit
2020-06-02 1:38 ` [PATCH v3 1/2] nl80211: " Aloka Dixit
2020-06-02 1:38 ` [PATCH v3 2/2] mac80211: " Aloka Dixit
2020-06-04 7:38 ` [PATCH v3 0/2] " Arend Van Spriel
2020-06-14 0:47 ` Aloka Dixit [this message]
2020-06-14 0:54 ` Aloka Dixit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=43f3871e11a02055a6662fc6aa5cf682@codeaurora.org \
--to=alokad@codeaurora.org \
--cc=arend.vanspriel@broadcom.com \
--cc=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).