Re: [PATCH v2 15/22] mac80211: don't calculate duration for S1G

Thomas Pedersen
2020-09-21T06:03:49Z

On 2020-09-18 03:52, Johannes Berg wrote:
> On Mon, 2020-08-31 at 13:55 -0700, Thomas Pedersen wrote:
>> For now just skip the duration calculation for frames
>> transmitted on the S1G band and avoid a warning.
>>
>> Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
>> ---
>> net/mac80211/tx.c | 4 ++++
>> 1 file changed, 4 insertions(+)
>>
>> diff --git a/net/mac80211/tx.c b/net/mac80211/tx.c
>> index d2136007e2eb..bef19616c5f0 100644
>> --- a/net/mac80211/tx.c
>> +++ b/net/mac80211/tx.c
>> @@ -82,6 +82,10 @@ static __le16 ieee80211_duration(struct
>> ieee80211_tx_data *tx,
>>
>> erp = txrate->flags & IEEE80211_RATE_ERP_G;
>>
>> + /* TODO */
>> + if (sband->band == NL80211_BAND_S1GHZ)
>> + return 0;
>
>
> I'm not even sure I'd leave a TODO there ... just say
>
> /* device is expected to do this */

Eventually it would be nice if mac80211 could calculate duration for
S1G? Do you know why it doesn't for HT/VHT?

--
thomas