From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>
Cc: linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
Ting-Ying Li <tingying.li@cypress.com>,
Ting-Ying Li <tingying.li@infineon.com>,
James Prestwood <prestwoj@gmail.com>
Subject: Re: [PATCH wireless-next 4/4] wifi: brcmfmac: Fix structure size for WPA3 external SAE
Date: Fri, 25 Apr 2025 10:40:34 +0200 [thread overview]
Message-ID: <44916ff608ee53238d79e57ee31fcbf86dfb672d.camel@sipsolutions.net> (raw)
In-Reply-To: <850b42ab-a637-4dd9-af18-e12523983ded@broadcom.com>
On Fri, 2025-04-25 at 09:57 +0200, Arend van Spriel wrote:
> On 4/24/2025 9:42 PM, Arend van Spriel wrote:
> > From: Ting-Ying Li <tingying.li@cypress.com>
> >
> > Add pmkid parameter in "brcmf_auth_req_status_le" structure to
> > align the buffer size defined in firmware "wl_auth_req_status"
> > structure.
> >
> > Signed-off-by: Ting-Ying Li <tingying.li@infineon.com>
>
> Hi Johannes,
>
> checkpatch issued a warning about From: and SoB: difference, but how to
> resolve it. Both emails are stale so it does not matter, but I lean
> towards using the infineon email address as that is likely the most
> recent identity used given the company history. Please advice.
I think you should probably keep whatever they used when they posted it.
> > + u8 pmkid[WLAN_PMKID_LEN];
>
> Sure like the wifibot checks. Do run checkpatch and compile test for
> every patch before sending it out, but no kerneldoc. Will need to add
> kerneldoc for this struct field.
Thanks :)
johannes
next prev parent reply other threads:[~2025-04-25 8:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-24 19:42 [PATCH wireless-next 0/4] wifi: brcmfmac: external auth support for Infineon devices Arend van Spriel
2025-04-24 19:42 ` [PATCH wireless-next 1/4] wifi: brcmfmac: support per-vendor cfg80211 callbacks and firmware events Arend van Spriel
2025-04-24 19:42 ` [PATCH wireless-next 2/4] wifi: brcmfmac: make per-vendor event map const Arend van Spriel
2025-04-24 19:42 ` [PATCH wireless-next 3/4] wifi: brcmfmac: cyw: support external SAE authentication in station mode Arend van Spriel
2025-04-24 19:42 ` [PATCH wireless-next 4/4] wifi: brcmfmac: Fix structure size for WPA3 external SAE Arend van Spriel
2025-04-25 7:57 ` Arend van Spriel
2025-04-25 8:40 ` Johannes Berg [this message]
2025-04-25 8:49 ` Arend van Spriel
2025-04-25 8:51 ` Johannes Berg
2025-04-25 8:52 ` Arend van Spriel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=44916ff608ee53238d79e57ee31fcbf86dfb672d.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=brcm80211@lists.linux.dev \
--cc=linux-wireless@vger.kernel.org \
--cc=prestwoj@gmail.com \
--cc=tingying.li@cypress.com \
--cc=tingying.li@infineon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox